-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Select] Fix bug on focus in controlled open #18857
Conversation
Details of bundle changes.Comparing: e112a44...8641961
|
Thank you for the new test case! Do you think that that you will have the time to look at why it fails? :) |
Wow, it's strange, I have no idea why the test passes in the local env but doesn't in the CI. I have updated the test to be failing before the fix. Maybe it will help, no idea 🤷♂️. |
No idea either on local setup works fine. |
We are lucky 😆, it does pass now. Thank you for having a look at it, let me know what you think of the new test :). Also, it would be great to have @eps1lon have a look at it as he might have the latest changes in mind. |
I'm going ahead. The change doesn't break any test, and we have a new test case if we need to follow up. |
Closes #18757
Fix a bug on controlled select