[AvatarGroup] Introduce new component #18707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
new feature
oliviertassinari
force-pushed
the
AvatarGroup
branch
2 times, most recently
from
69e8ced
to
5cbdb9d
Compare
|
@material-ui/lab: parsed: +0.44% , gzip: +0.21% Details of bundle changes.Comparing: a973b2f...8a64ad8
|
oliviertassinari
force-pushed
the
AvatarGroup
branch
3 times, most recently
from
27709a7
to
5b3c1c9
Compare
merceyz
reviewed
Dec 6, 2019
| /** | ||
| * The avatars to stack. | ||
| */ | ||
| children: React.ReactNode; |
There was a problem hiding this comment.
A ReactNode can be undefined, should probably be ReactElement
There was a problem hiding this comment.
Would it work after React.Children.toArray(undefined)?
There was a problem hiding this comment.
Oh or just?
children?: React.ReactNode;There was a problem hiding this comment.
I had a look at the codebase, we don't have much consistency on this point.
|
Nice job so far. Looking at the benchmarks, Atlas and Treasury both allow passing in the data, and generate the required Avatars. While we've generally favoured composed components, that could be nice as an option. Chakra (or whoever's code they copied) supports the ability to set the max number of avatars before truncation - that seems like a nice thing to automate. (It helps that their Avatar also has a name prop.). Also, the prop to adjust the negative margin might have some merit. Other than that, it looks pretty clean! |
|
@mbrookes Thanks for the review, I have wondered about these points.
|
That was what I had in mind.
Sure, everything can be done by the developer, but then, why use the component? I'm not wedded to this, but it seems like it might have some value.
I was thinking more of a limited set of values, each with their own class. |
|
To be honest, I don't know. I'm not sure how people will use this component. The nice thing about your proposal is that they are incremental, we should be able to add them later down the road when we see a compelling reason to do so. |
mbrookes
reviewed
Dec 7, 2019
oliviertassinari
force-pushed
the
AvatarGroup
branch
3 times, most recently
from
5b3fb6b
to
69aeb1f
Compare
oliviertassinari
force-pushed
the
AvatarGroup
branch
from
69aeb1f
to
2b9490e
Compare
oliviertassinari
force-pushed
the
AvatarGroup
branch
from
2b9490e
to
8a64ad8
Compare
|
Awesome work!! |
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17611.
Benchmark