-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Batch changes #18629
[core] Batch changes #18629
Conversation
oliviertassinari
commented
Nov 30, 2019
•
edited
Loading
edited
- [docs] Custom work, consistent pricing - f369f2c
- [docs] Templates, improve title - be527d6: test if it helps with SEO.
- [CHANGELOG] Include v3.9.4 - da85ab1
- [docs] Remove Spectrum - 14c0e7d: Used at 70% in place of StackOverflow. The rest of the 30% can probably be asked on GitHub.
- [Tabs] Improve performance demos - 0369bfc: only render the visible tab panel.
- [docs] Reduce confusion - 6038ea5: better wording. Closes @material-ui/styles vs @material-ui/core/styles #17854.
- [docs] Renamve Overview -> Theming - b7ce540: asked by @mbrookes.
- [docs] Prefer singular for the component - 0e128a8: Closes [docs] main menu component names - use singular; use alias for select #17644.
- [Stepper] Allow multiple states - be976d3: Closes StepIcon active / completed / error states are mutually exclusive in the context of styling, at odds with StepLabel #15437.
- [docs] Remove crosswordsolver sponsor - 9b24309
- [Table] Remove outer margins - 62512af
Details of bundle changes.Comparing: 386bbf9...7c8377c
|
docs/src/pages/guides/minimizing-bundle-size/minimizing-bundle-size.md
Outdated
Show resolved
Hide resolved
@@ -3,7 +3,7 @@ title: Button React component | |||
components: Button, ButtonGroup, Fab, IconButton, ButtonBase, Zoom | |||
--- | |||
|
|||
# Buttons | |||
# Button | |||
|
|||
<p class="description">Buttons allow users to take actions, and make choices, with a single tap.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we singularise the descriptions where appropriate?
"A button allows..."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a preference, as you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, I believe that it's another concern, that the current documentation uses singular vs plural, at random, between the different pages.
…-size.md Co-Authored-By: Matt <[email protected]>
732dc56
to
7984d2c
Compare
So, it seems there is significant precedence for using Radio to refer to Radio buttons (or the Radio component of Radio buttons): Radio(s) – 18Adobe Spectrum: Radio Radio button(s) – 12MD Spec: Radio buttons Other – 5Lightning: Radio groups On that basis, let's change it to your preference. |
Thanks for the analysis, ok, I'm happy either way :). |
This reverts commit 7984d2c.