Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Batch changes #18629

Merged
merged 17 commits into from
Dec 2, 2019
Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 30, 2019

@oliviertassinari oliviertassinari added the umbrella For grouping multiple issues to provide a holistic view label Nov 30, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Nov 30, 2019

Details of bundle changes.

Comparing: 386bbf9...7c8377c

bundle Size Change Size Gzip Change Gzip
docs.landing ▼ -605 B (-1.14% ) 52.4 kB ▼ -41 B (-0.36% ) 11.4 kB
StepLabel ▼ -10 B (-0.01% ) 67.5 kB ▲ +11 B (+0.05% ) 21.1 kB
StepButton ▼ -10 B (-0.01% ) 81.1 kB ▲ +10 B (+0.04% ) 25.5 kB
@material-ui/core ▼ -10 B (-0.00% ) 354 kB ▲ +6 B (+0.01% ) 96.7 kB
StepIcon ▼ -10 B (-0.02% ) 63.5 kB ▲ +3 B (+0.02% ) 19.7 kB
@material-ui/core[umd] ▲ +8 B (0.00% ) 311 kB ▲ +12 B (+0.01% ) 89.6 kB
@material-ui/lab -- 173 kB -- 52.1 kB
@material-ui/styles -- 51 kB -- 15.3 kB
@material-ui/system -- 14.8 kB -- 4.06 kB
AppBar -- 62.7 kB -- 19.5 kB
Autocomplete -- 127 kB -- 39.6 kB
Avatar -- 61.7 kB -- 19.3 kB
Backdrop -- 66.6 kB -- 20.5 kB
Badge -- 64.2 kB -- 19.9 kB
BottomNavigation -- 61.3 kB -- 19.1 kB
BottomNavigationAction -- 74.3 kB -- 23.4 kB
Box -- 69.6 kB -- 21 kB
Breadcrumbs -- 66.9 kB -- 20.8 kB
Button -- 78.3 kB -- 23.9 kB
ButtonBase -- 72.8 kB -- 22.7 kB
ButtonGroup -- 80.9 kB -- 24.8 kB
Card -- 61.6 kB -- 19.2 kB
CardActionArea -- 73.9 kB -- 23.2 kB
CardActions -- 60.9 kB -- 19 kB
CardContent -- 60.9 kB -- 19 kB
CardHeader -- 64 kB -- 20 kB
CardMedia -- 61.2 kB -- 19.2 kB
Checkbox -- 80.6 kB -- 25.3 kB
Chip -- 81.4 kB -- 24.8 kB
CircularProgress -- 63 kB -- 19.8 kB
ClickAwayListener -- 3.87 kB -- 1.56 kB
Collapse -- 66.8 kB -- 20.6 kB
colorManipulator -- 3.85 kB -- 1.52 kB
Container -- 62 kB -- 19.3 kB
CssBaseline -- 56.4 kB -- 17.6 kB
Dialog -- 81.5 kB -- 25.4 kB
DialogActions -- 61 kB -- 19 kB
DialogContent -- 61.1 kB -- 19.1 kB
DialogContentText -- 62.9 kB -- 19.7 kB
DialogTitle -- 63.2 kB -- 19.7 kB
Divider -- 61.5 kB -- 19.2 kB
docs.main -- 609 kB -- 194 kB
Drawer -- 83.2 kB -- 25.2 kB
ExpansionPanel -- 70.1 kB -- 21.8 kB
ExpansionPanelActions -- 61 kB -- 19 kB
ExpansionPanelDetails -- 60.8 kB -- 19 kB
ExpansionPanelSummary -- 76.9 kB -- 24.2 kB
Fab -- 75.6 kB -- 23.5 kB
Fade -- 22.4 kB -- 7.71 kB
FilledInput -- 72.3 kB -- 22.4 kB
FormControl -- 63.2 kB -- 19.6 kB
FormControlLabel -- 64.4 kB -- 20.1 kB
FormGroup -- 60.9 kB -- 19 kB
FormHelperText -- 62.1 kB -- 19.4 kB
FormLabel -- 62.4 kB -- 19.2 kB
Grid -- 64 kB -- 20 kB
GridList -- 61.4 kB -- 19.2 kB
GridListTile -- 62.6 kB -- 19.5 kB
GridListTileBar -- 62.1 kB -- 19.3 kB
Grow -- 23.1 kB -- 7.83 kB
Hidden -- 64.8 kB -- 20.3 kB
Icon -- 61.7 kB -- 19.2 kB
IconButton -- 75 kB -- 23.3 kB
Input -- 71.3 kB -- 22.1 kB
InputAdornment -- 64 kB -- 20 kB
InputBase -- 69.4 kB -- 21.7 kB
InputLabel -- 64.2 kB -- 20 kB
LinearProgress -- 64.2 kB -- 20 kB
Link -- 65.5 kB -- 20.6 kB
List -- 61.3 kB -- 19 kB
ListItem -- 75.9 kB -- 23.6 kB
ListItemAvatar -- 61 kB -- 19 kB
ListItemIcon -- 61.1 kB -- 19 kB
ListItemSecondaryAction -- 60.9 kB -- 19 kB
ListItemText -- 63.8 kB -- 19.9 kB
ListSubheader -- 61.6 kB -- 19.3 kB
Menu -- 87.1 kB -- 26.8 kB
MenuItem -- 77 kB -- 23.9 kB
MenuList -- 64.9 kB -- 20.2 kB
MobileStepper -- 66.6 kB -- 20.8 kB
Modal -- 14.2 kB -- 4.99 kB
NativeSelect -- 75.6 kB -- 23.7 kB
NoSsr -- 2.19 kB -- 1.03 kB
OutlinedInput -- 72.8 kB -- 22.6 kB
Paper -- 61.1 kB -- 19 kB
Popover -- 81.5 kB -- 25.1 kB
Popper -- 28.6 kB -- 10.2 kB
Portal -- 2.87 kB -- 1.29 kB
Radio -- 81.5 kB -- 25.6 kB
RadioGroup -- 62.1 kB -- 19.4 kB
Rating -- 68.9 kB -- 22.1 kB
RootRef -- 4.43 kB -- 1.67 kB
Select -- 113 kB -- 33.5 kB
Skeleton -- 61.4 kB -- 19.3 kB
Slide -- 24.5 kB -- 8.32 kB
Slider -- 74.5 kB -- 23.3 kB
Snackbar -- 76 kB -- 23.7 kB
SnackbarContent -- 64.5 kB -- 20.2 kB
SpeedDial -- 84.9 kB -- 26.7 kB
SpeedDialAction -- 115 kB -- 36.5 kB
SpeedDialIcon -- 63.5 kB -- 19.9 kB
Step -- 61.5 kB -- 19.2 kB
StepConnector -- 61.6 kB -- 19.3 kB
StepContent -- 67.9 kB -- 21.2 kB
Stepper -- 63.6 kB -- 20 kB
styles/createMuiTheme -- 15.6 kB -- 5.47 kB
SvgIcon -- 61.9 kB -- 19.3 kB
SwipeableDrawer -- 90.6 kB -- 28 kB
Switch -- 80 kB -- 25 kB
Tab -- 75.2 kB -- 23.7 kB
Table -- 61.4 kB -- 19.2 kB
TableBody -- 61 kB -- 19 kB
TableCell -- 62.9 kB -- 19.7 kB
TableFooter -- 61 kB -- 19 kB
TableHead -- 61 kB -- 19 kB
TablePagination -- 140 kB -- 40.7 kB
TableRow -- 61.4 kB -- 19.1 kB
TableSortLabel -- 76.2 kB -- 23.9 kB
Tabs -- 84.3 kB -- 26.5 kB
TextareaAutosize -- 5.06 kB -- 2.11 kB
TextField -- 122 kB -- 35.5 kB
ToggleButton -- 75 kB -- 23.7 kB
ToggleButtonGroup -- 62.1 kB -- 19.4 kB
Toolbar -- 61.2 kB -- 19.1 kB
Tooltip -- 99.4 kB -- 31.4 kB
TreeItem -- 72.5 kB -- 22.8 kB
TreeView -- 65.3 kB -- 20.4 kB
Typography -- 62.5 kB -- 19.5 kB
useAutocomplete -- 12.4 kB -- 4.56 kB
useMediaQuery -- 2.49 kB -- 1.05 kB
Zoom -- 22.5 kB -- 7.71 kB

Generated by 🚫 dangerJS against 7c8377c

docs/src/pages.js Show resolved Hide resolved
@@ -3,7 +3,7 @@ title: Button React component
components: Button, ButtonGroup, Fab, IconButton, ButtonBase, Zoom
---

# Buttons
# Button

<p class="description">Buttons allow users to take actions, and make choices, with a single tap.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we singularise the descriptions where appropriate?

"A button allows..."?

Copy link
Member Author

@oliviertassinari oliviertassinari Dec 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a preference, as you prefer.

Copy link
Member Author

@oliviertassinari oliviertassinari Dec 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I believe that it's another concern, that the current documentation uses singular vs plural, at random, between the different pages.

@mbrookes
Copy link
Member

mbrookes commented Dec 1, 2019

So, it seems there is significant precedence for using Radio to refer to Radio buttons (or the Radio component of Radio buttons):

Radio(s) – 18

Adobe Spectrum: Radio
React Suite: Radio
Atlaskit: Radio
Orbit: Radio
Chakra: Radio
Ebay: Radio
Baseweb: Radio
React Bootstrap: Radios
Smooth UI: Radios
Element: Radio
Ant: Radio
Bootstrap: Radios
Vuetify: Radios
Primer: Radios
Blueprint: Radio
Evergreen: Radio
Zendesk Garden: Radio
Cosmos: Radio

Radio button(s) – 12

MD Spec: Radio buttons
MCW: Radio Buttons
Bulma: Radio / Radio button
Grommet: RadioButton
Shopify: Radio button
Pinterest: RadioButton
Carbon: Radio button
Prime: RadioButton
MD Bootstrap: Radio button
Syncfusion: Radio button
Mobiscroll: Radio button
ReactStrap: Radio buttons

Other – 5

Lightning: Radio groups
DevExtreme: Radio group
Semantic UI: Radio checkbox (WTF?)
Sancho UI: Check (Also WTF!)
Fabric: "ChoiceGroup AKA radio buttons" (Seriously, WTF M$?)

On that basis, let's change it to your preference.

@oliviertassinari
Copy link
Member Author

Thanks for the analysis, ok, I'm happy either way :).

This reverts commit 7984d2c.
@oliviertassinari oliviertassinari merged commit 693b86e into mui:master Dec 2, 2019
@oliviertassinari oliviertassinari deleted the batch-changes-v14 branch December 2, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
4 participants