Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Document value equality check #18516

Merged
merged 5 commits into from
Nov 24, 2019
Merged

[Autocomplete] Document value equality check #18516

merged 5 commits into from
Nov 24, 2019

Conversation

ChawinTan
Copy link

@ChawinTan ChawinTan commented Nov 23, 2019 •
edited by oliviertassinari
Loading

Closes #18499

@mui-pr-bot
Copy link

mui-pr-bot commented Nov 23, 2019 •
edited
Loading

No bundle size changes comparing 75697b3...5034e69

Generated by 🚫 dangerJS against 5034e69

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: autocomplete This is the name of the generic UI component, not the React module! labels Nov 23, 2019
@oliviertassinari oliviertassinari changed the title #18499 autocomplete documentation [Autocomplete] documentation value equality check Nov 23, 2019
@oliviertassinari oliviertassinari changed the title [Autocomplete] documentation value equality check [Autocomplete] Document value equality check Nov 23, 2019
@oliviertassinari oliviertassinari force-pushed the #18499-autocomplete-documentation branch 2 times, most recently from 27b25dc to b7b07e5 Compare November 23, 2019 15:21
oliviertassinari
oliviertassinari reviewed Nov 23, 2019
View reviewed changes
packages/material-ui-lab/src/useAutocomplete/useAutocomplete.d.ts
@@ -153,6 +153,9 @@ export interface UseAutocompleteProps {
options?: any[];
/**
* The value of the autocomplete.
*
* The value must have reference equality with the option in order to be selected.
* You can customize the equality behavior with the `getOptionSelected` prop.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the getOptionSelected prop

It's not implemented yet, but it's an incentive to push #18443 further.

@oliviertassinari oliviertassinari merged commit a186ae3 into mui:master Nov 24, 2019
@oliviertassinari
Copy link
Member

Thanks

@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
This was referenced Feb 23, 2020
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autocomplete defaultvalue and value for options with checkbox only works if options reference is passed
3 participants
@ChawinTan @mui-pr-bot @oliviertassinari