[ButtonBase] Test keyboard events of child elements #18318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do receive the keyboard events but do not trigger the pointer events
eps1lon
commented
Nov 11, 2019
| const button = getByRole('button'); | ||
| button.focus(); | ||
|
|
||
| fireEvent.keyDown(document.activeElement || document.body, { |
There was a problem hiding this comment.
This is a bug currently. Space should trigger click on keyUp not keyDown (following <button />.
|
No bundle size changes comparing db6ed0d...80bcb51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test extracted from #18271
We currently don't expect
event.stopPropagationbut manually check if the event is explicitly dispatched on the button i.e. are we currently focusing the button?I think this makes for this example specifically more sense. I guess keyboard events are fundamentally different than pointer events in this regard. With cursor events we can't possibly expect that the user knows exactly what elements they want to target (since the DOM is hidden). For keyboard events we can since focused elements are perceivable.