-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Batch changes #18264
Merged
oliviertassinari
merged 11 commits into
mui:master
from
oliviertassinari:batch-small-changes-v14
Nov 9, 2019
Merged
[core] Batch changes #18264
oliviertassinari
merged 11 commits into
mui:master
from
oliviertassinari:batch-small-changes-v14
Nov 9, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oliviertassinari
commented
Nov 7, 2019
•
edited
Loading
edited
- [docs] Start a test with Tidelift 42ab37a: Add a third advertiser in the in-house ads. They are all % commissioned, $100 per workable lead in the case of Tidelift. We will be able to compare them at the end of the month.
- [docs] Change split to 50/50 89a58c4: CodeFund keeps performing better than Carbon, month after month.
- [docs] Force core peer dependency b4da9d6: I have noticed this issue with the CodeSandbox edit links of the demos in the lab. For instance, the rating demos.
- [example] Replace legacy CDN preview URL f78ca7f: rawgit.com is deprecated
- [docs] Improve ad display 8d6080b: Prevent Carbon ad to jump. Detect CodeFund missing ad.
- [Autocomplete] Fix mobile demo cda43cd. Remove the min-height on mobile. Remove the leftover debug prop.
- [Slider] Fix coarse mark label position 0ae930e: Follow-up on the coarse pull request. I have forgotten to handle the mark label issue.
- [docs] Add Diamond Sponsors 7f0df1b: It seems to work well for Vuetify. I want to try it for us (with smaller icons, like Vue).
oliviertassinari
added
the
umbrella
For grouping multiple issues to provide a holistic view
label
Nov 7, 2019
Details of bundle changes.Comparing: 262c8cf...98bb6ce
|
eps1lon
reviewed
Nov 8, 2019
oliviertassinari
force-pushed
the
batch-small-changes-v14
branch
from
November 8, 2019 11:57
631f82f
to
d30dd06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.