-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Force usage of block language #18069
Conversation
Thanks for looking at it, I have dodged the problem in #18041. |
Details of bundle changes.Comparing: b16ff50...a4d2eec
|
@oliviertassinari Oh, so should I close this PR? |
@mtsmfm The approach taken here is different. I'm wondering. |
8d3069e
to
6285109
Compare
What about forcing a language? |
You meant adding class like "language-none", right? |
Once I tried such a way but I found marked.js can't add |
ca46276
to
a4d2eec
Compare
@mtsmfm I have updated the pull request to explore another strategy. It forces the usage of a language. I'm curious to see how many demo pages it will impact. |
a4d2eec
to
3af91c5
Compare
@mtsmfm Alright, it seems that we can force the language without breaking any page. It might help to prevent such a problem in the future :). Thank you for taking the time to work on the problem ❤️ |
This reverts commit 751ea52.
Production
https://material-ui.com/guides/minimizing-bundle-size/
My branch