[core] Custom deepmerge implementation #17982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
remove-deepmerge-dependency
branch
from
82163e3
to
0abe826
Compare
|
@material-ui/core: parsed: -0.46% 😍, gzip: -0.52% 😍 Details of bundle changes.Comparing: cdc4b98...5ace5ab
|
|
Performance seems to be better too. |
oliviertassinari
added
performance
PR: ready to ship
and removed
core
joshwooding
approved these changes
Oct 22, 2019
eps1lon
previously requested changes
Oct 22, 2019
eps1lon
added
PR: needs revision
|
What do you mean by prototype pollution? Should we add a test case about it? The aim of this new module is to support simple objects deep merge. |
There are several CVEs out there describing this security issue. Since this is a public function and we don't sanitize the passed theme and don't control the environment we need to address it. Wide range of source: |
oliviertassinari
force-pushed
the
remove-deepmerge-dependency
branch
2 times, most recently
from
a5a2d23
to
8b20a28
Compare
|
@eps1lon Thanks for the resources. I'm adding a test case, well spotted. |
oliviertassinari
force-pushed
the
remove-deepmerge-dependency
branch
from
8b20a28
to
5ace5ab
Compare
oliviertassinari
removed
the
PR: needs revision
joshwooding
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give a try. I'm curious about the bundle size reduction. I guess, 500 B.
Closes #17981.