-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve fixed app bar placement section #17896
[docs] Improve fixed app bar placement section #17896
Conversation
No bundle size changes comparing ec7b5e9...6bf3bc9 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6bf3bc9:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow-up pull request. In:
<div>
<Appbar position="fixed"></Appbar>
<div className={classes.offset}> {/* to accomdate for top white space */}
</div>
You can fix the syntax and apply our style convention.
I have made the changes, can you kindly review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates. I have added a new commit, it was faster for me. Let me know what you think.
I think it is awesome now 👍👍👍👍 |
This PR builds on improvements suggested in #17878
Closes #16844