Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ListSubheader] Reduce specificity of typescript type #17715

Merged
merged 3 commits into from
Oct 20, 2019
Merged

[ListSubheader] Reduce specificity of typescript type #17715

merged 3 commits into from
Oct 20, 2019

Conversation

sakulstra
Copy link
Contributor

I looked trough the other components and most of them just have a less specific type (the one I used here as well).

@sakulstra sakulstra changed the title Reduce specificity of typescript type [ListSubheader] Reduce specificity of typescript type Oct 5, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 7, 2019 •
edited
Loading

No bundle size changes comparing 6b9ecbe...f4cd998

Generated by 🚫 dangerJS against f4cd998

@eps1lon eps1lon added package: material-ui Specific to @mui/material typescript labels Oct 7, 2019
eps1lon
eps1lon previously requested changes Oct 7, 2019
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather see this fixed by using OverridableComponent. This PR will allow excess props otherwise.

@oliviertassinari oliviertassinari added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed package: material-ui Specific to @mui/material labels Oct 9, 2019
@pablolmiranda
Copy link

I think the issue here is the previous defaultComponent props was named component but the type definition was not updated

@sakulstra
Copy link
Contributor Author

sorry for not getting back at this 😞

as a heads up - I will try to fix it on Friday

@sakulstra
Copy link
Contributor Author

@eps1lon could you recheck this?

@oliviertassinari oliviertassinari removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Oct 18, 2019
@eps1lon eps1lon added the package: material-ui Specific to @mui/material label Oct 20, 2019
@eps1lon eps1lon merged commit 17c0e30 into mui:master Oct 20, 2019
@eps1lon
Copy link
Member

eps1lon commented Oct 20, 2019

@sakulstra Thanks for sticking with it!

@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon Awaiting requested review from eps1lon

Assignees
No one assigned
Labels
package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Typescript] ListSubheader reject ListItem as component prop
5 participants
@sakulstra @mui-pr-bot @pablolmiranda @eps1lon @oliviertassinari