[styles] Change the withTheme API #14565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
breaking change
package: styles
56 tasks
oliviertassinari
force-pushed
the
change-with-theme-api
branch
from
410541e to
bb1182c
Compare
joshwooding
approved these changes
Feb 17, 2019
oliviertassinari
force-pushed
the
change-with-theme-api
branch
from
bb1182c to
ebfb739
Compare
oliviertassinari
added
good first issue
This was referenced Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have realized that #14560 was too ambitious to be done in a single pass. I'm breaking it into different chunks.
Breaking changes
Remove the first option argument of
withTheme(). The first argument was a placeholder for a potential future option. We have never found a need for it. It's time to remove this argument. It matches the emotion and styled-components API.