Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Increase React peer dependency to v16.8.0 #14432

Merged
merged 1 commit into from
Feb 6, 2019
Merged

[core] Increase React peer dependency to v16.8.0 #14432

merged 1 commit into from
Feb 6, 2019

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 6, 2019 •
edited
Loading

The upgrade path to React 16.8.0 should be pretty easy for our user. Introducing this breaking change in v4 enable us the following:

  • We can remove the recompose dependency and use the new React.memo() API.
  • Before or after v4 is out, we can gradually migrate the core components to use the Hook API.

@oliviertassinari oliviertassinari added this to the v4 milestone Feb 6, 2019
@eps1lon
Copy link
Member

eps1lon commented Feb 6, 2019

Happy hooks day y'all 😄

Could you rebase with #14433 first to be safe about changed dependencies?

@oliviertassinari oliviertassinari force-pushed the react-16.8.0 branch 3 times, most recently from 25c5391 to 8f5eeee Compare February 6, 2019 11:21
@oliviertassinari oliviertassinari merged commit 2c3c897 into mui:next Feb 6, 2019
@oliviertassinari oliviertassinari deleted the react-16.8.0 branch February 6, 2019 11:48
@eps1lon eps1lon mentioned this pull request Feb 7, 2019
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
v4
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviertassinari @eps1lon