[core] Drop node 6 support #14379
Merged
[core] Drop node 6 support #14379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 tasks
eps1lon
commented
Feb 1, 2019
| @@ -14,7 +14,7 @@ Because Googlebot uses a web rendering service (WRS) to index the page content, | |||
|
|
|||
| ## Server | |||
|
|
|||
| Because Material-UI supports server-side rendering, we need to support the latest, stable releases of [Node.js](https://github.com/nodejs/node). We try to support the [last active LTS version](https://github.com/nodejs/Release#lts-schedule1). Right now, we support **node v6.x** and newer versions. | |||
| Because Material-UI supports server-side rendering, we need to support the latest, stable releases of [Node.js](https://github.com/nodejs/node). We try to support the [last active LTS version](https://github.com/nodejs/Release#lts-schedule1). Right now, we support **node v8.x** and newer versions. | |||
There was a problem hiding this comment.
Question about that statement: Shouldn't it always have been "oldest LTS version"? The "latest active LTS version" would be node 10 now.
eps1lon
commented
Feb 2, 2019
docs/src/pages/getting-started/supported-platforms/supported-platforms.md
Outdated
Show resolved
Hide resolved
…latforms.md Co-Authored-By: eps1lon <[email protected]>
oliviertassinari
approved these changes
Feb 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 6 will reach end of life in April 2019. The upcoming v4 provides a good opportunity to drop support for it (although a little bit to early depending on our release date).
Testing node 8 in CI which helps testing node 8 support. We never actually ran our tests with node 6. Might not work due to previous issues encountered in #13818.
Part of #13663
Breaking change
Require node >= 8 (was 6 previously)