Expand last partition after creating the partitions #96
Conversation
|
the broken job is also broken on master. |
|
Im not sure if its enough with this. AFAIK the problem was that this plugin on yip does not support GPT partitions, but I dont see any changes to those. Maybe it was wrong and it does support GPT partitions already? |
|
I don't know. This is not supposed to fix everything. Only porting this specific fix to yip. In the meantime. I simply switched to this plugin in immucore and it expands the partition just fine (in the context of this: kairos-io/kairos#1448). My plan is to have a look at what the other 2 implementations did (kairos-agent and immucore) and try to predict what could go wrong. I'm afraid there won't be any broken tests to help. |
|
One big difference is that the |
|
Unless we are not using it to do so. |
|
I switched both the kairos-agent and immucore to the yip implementation and after installation I get this: I guess |
|
noiiiice! |
|
FYI @jimmykarily you got fixes for the tests in this PR: https://github.com/mudler/yip/pull/95/files As long as you ignore the changes in the command.go file, the rest of the changes should fix the tests. Do you want them in this patch or want me to send a different PR with just those fixes? Im not gonna merge the linked PR as Im not happy with it but the test fixes would be good to have. |
|
I think a separate PR which we merge and I rebase is the best option, if you have time to prepare that. Otherwise I can try that. |
yep, give me 5 and I'll send it |
|
oh @jimmykarily seems like the only fix is this patch as gox is no longer used: My PR doesnt hit this because it comes from a fork, while yours is run from a branch in the main repo. Do we want a full PR for this? Is only removing 2 lines... |
|
Just push a commit here, it's ok |
|
@jimmykarily , the partitioner plugin @Itxaka is refering to is https://github.com/kairos-io/kairos-agent/blob/main/pkg/cloudinit/layout_plugin.go - do we need also to backport the patch over there? |
|
I'm testing this here: kairos-io/kairos#1497 I need to see if this can be used both in kairos-agent and immucore. Switching to this implementation and running the e2e tests is a good way to know. |
scratch that, saw the PR, I'm still confused - this used to benecessary for GPT.. because was using sgdisk instead of parted? |
Check my 2 comments here: #96 (comment) |
We applied the same fix here: https://github.com/kairos-io/kairos-agent/pull/32/files#diff-9bf4494bcc865684d4aeae7837925b1732855e863067c12a61f6f38e2fc16716 but we now want to use the yip implementation everywhere: - kairos-agent (see link above) - immucore: https://github.com/kairos-io/immucore/blob/0811f0f054b086708727a441988d3e93905838a1/internal/utils/layout_plugin.go#L18 Signed-off-by: Dimitris Karakasilis <[email protected]>
We no longer using it Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
force-pushed
the
1448-expand-partitions-after-creation
branch
from
7066ac1
to
4758d80
Compare
to get this fix: mudler/yip#96 Signed-off-by: Dimitris Karakasilis <[email protected]>
to get this fix: mudler/yip#96 and stop "replacing" in go.mod. We are not 100% sure what the replacement was there for but we'll test and see. Also remove replace of elemental-cli which was there only for debugging Signed-off-by: Dimitris Karakasilis <[email protected]>
to get this fix: mudler/yip#96 Signed-off-by: Dimitris Karakasilis <[email protected]>
We applied the same fix here:
https://github.com/kairos-io/kairos-agent/pull/32/files#diff-9bf4494bcc865684d4aeae7837925b1732855e863067c12a61f6f38e2fc16716
but we now want to use the yip implementation everywhere: