Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basics.image being ignored / profile photo missing #149

Open
garymm opened this issue Jan 18, 2022 · 2 comments
Open

basics.image being ignored / profile photo missing #149

garymm opened this issue Jan 18, 2022 · 2 comments

Comments

@garymm
Copy link

garymm commented Jan 18, 2022

I expect to see my profile photo taken from basics.image, but it is not:

Source:

{
    "basics": {
         "image": "https://media-exp1.licdn.com/dms/image/C5603AQHYBCIryEnWDQ/profile-displayphoto-shrink_800_800/0/1589651499542?e=1648080000&v=beta&t=0dpk7IJnhCTmWQSkYbjp_RRnZmIUZ0UjYl2eKR7uOtQ",
...

HTML output:

<img class="media-object img-circle center-block" data-src="holder.js/100x100" alt="Gary Miguel" src="https://s.gravatar.com/avatar/bc18c349133a64fe2c82a051a34adf5d?s=100&amp;r=pg&amp;d=mm" itemprop="image">

Currently rendered at:
https://registry.jsonresume.org/garymm?theme=elegant

From gist:
https://gist.github.com/garymm/35c108e4d0d8ee0be17c1a940584f6a9

Thanks for any help!

@DerEinePete
Copy link

Hi,
I do not know why, but you need to set the property basics.picture.

@gapuchi
Copy link

gapuchi commented Jun 17, 2022

There is a discrepancy between the theme and JSON Resume Schema. The schema uses image while this theme uses picture - https://github.com/jsonresume/theme-utils/blob/3ecd6dfe10f7a2abac366b40ec9065a4e89292e4/basics.js#L42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants