Add support for sudo and mu auth scope #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikap
requested changes
Apr 20, 2024
| if Mu::truthy? ENV['ALLOW_MU_AUTH_SUDO'] | ||
| options[:headers] = { 'mu-auth-sudo': 'true' } | ||
| else | ||
| log.error "Error, sudo request but service lacks ALLOW_MU_AUTH_SUDO header" |
There was a problem hiding this comment.
Shouldn't we also raise an error here instead of only logging one? Query will now still be executed with a non-sudo SPARQL client.
There was a problem hiding this comment.
Should I go with raise?
raise "Error, sudo request but service lacks ALLOW_MU_AUTH_SUDO header"There was a problem hiding this comment.
Yes, seems more in line with the JS template to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains similar changes to mu-semtech/mu-javascript-template@56e185e .
It extends the
queryandupdatefunctions and provides a transition path to using scopes instead of sudo where possible (once the scopes feature lands).