Use a JS only tail implementation #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teid
commented
Mar 21, 2020
lib/tail.js
Outdated
| } | ||
| }); | ||
|
|
||
| function readLastLinesIfPossible(path, onLineCb) { |
There was a problem hiding this comment.
I had to add this function, because the native tail does it. But the JS lib does not
teid
commented
Mar 21, 2020
teid
force-pushed
the
useJsTail
branch
2 times, most recently
from
680d9c9 to
fc35ea6
Compare
|
@teid is it ready to be reviewed? |
|
Yes @mthenw, I validated that this change fixes the issue I had on the Windows server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have the same behaviour between Linux and Windows (related to this issue: #197), I've switched to a lib that provide a JS only tail
This is still a work in progress, I still have to test it on Windows server, but I don't have it right now.
With this implementation, it's difficult to reproduce the same, so I changed the output (also, I allowed stdin to be followed along with other files):
Let me know what do you think about it :)