Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce conditions better #7796

Merged
merged 6 commits into from
Oct 8, 2024

Conversation

NBKelly
Copy link
Collaborator

@NBKelly NBKelly commented Oct 8, 2024

  • Stripped the trash-on-tagged and enforce-conditions stuff out of the card maps
  • stripped the trash-on-tagged stuff out of the engine entirely and redeffed it in terms of card events
  • beckman/zona sul still pass all tests

I think this should debloat the gamestate a tiny bit, and also strips one repetitive function out of engine (from fake-checkpoint), which is nice

@NoahTheDuke
Copy link
Collaborator

Can't use a simple trigger-event if you're gonna trash stuff in the abilities. things will get out of sync. gotta use trigger-event-sync or -simult out checkpoint.

@NoahTheDuke NoahTheDuke merged commit 9215470 into mtgred:master Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants