Skip to content
This repository has been archived by the owner on Dec 21, 2018. It is now read-only.

Add Magic Card Market set names for each set #67

Open
Sembiance opened this issue Aug 4, 2015 · 5 comments
Open

Add Magic Card Market set names for each set #67

Sembiance opened this issue Aug 4, 2015 · 5 comments
Labels

Comments

@Sembiance
Copy link
Contributor

Adding the set name used by https://www.magiccardmarket.eu/Expansions would allow those that use the MTGJSON data to more easily integrate into the pricing data provided by that site.

@florentdouine
Copy link
Contributor

Magiccardmarket has an API for this kind of datas.

@jenjia
Copy link

jenjia commented Aug 20, 2015

This would be so lovely, I am trying to use their API to get prices, and need to parse the sets from mtgjson to theirs, and this is so hard and inaccurate for me, because they have their own way to classify cards by sets.
But actually if you do this, this could improve the database, since they have all cards!! (and is not so hard I think since they have a API for fetch info) while magiccards.info miss some. eg. "Siege Rhino" has 3 versions in MagicCardMarket and just 2 in magiccards.info

@lsmoura
Copy link
Contributor

lsmoura commented Oct 16, 2015

Can someone elaborate on this? How is this different than the name of the set already provided on the JSON files?

  "name": "Battle for Zendikar",
  "code": "BFZ",
  "magicCardsInfoCode": "bfz",
  "releaseDate": "2015-10-02",
  "border": "black",
  "type": "expansion",
  "block": "Battle for Zendikar",

@jenjia
Copy link

jenjia commented Oct 16, 2015

For example in KTK-x.json :

{
...
"type": "Creature — Rhino",
...
"name": "Siege Rhino",
"printings": [
"pPRE",
"KTK"
]
}

So, Siege Rhino printings list is pPRE (Prerelease), KTK (Khans of Tarkir).
In https://www.magiccardmarket.eu/Products/Singles/Khans+of+Tarkir/Siege+Rhino

We can see that Siege Rhino has 3 printings:

  1. Clash Pack - https://www.magiccardmarket.eu/Products/Singles/Clash+Pack+Promos/Siege+Rhino
  2. Khans of Tarkir: Promos - https://www.magiccardmarket.eu/Products/Singles/Khans+of+Tarkir%3A+Promos/Siege+Rhino
  3. Khans of Tarkir - https://www.magiccardmarket.eu/Products/Singles/Khans+of+Tarkir/Siege+Rhino

Therefor we can conclude that in MTGJson we miss Clash Pack printings listening and that "pPRE" set (Prerelease) is linked to their set named: "Khans of Tarkir: Promos"

@lsmoura
Copy link
Contributor

lsmoura commented Oct 16, 2015

Got it!

I'll try to think about how to implement this...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants