Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR in dll #323

Open
Zibri opened this issue Jul 30, 2023 · 8 comments
Open

ERROR in dll #323

Zibri opened this issue Jul 30, 2023 · 8 comments

Comments

@Zibri
Copy link

Zibri commented Jul 30, 2023

in this situation:

    shell: msys2 {0}
    run: |
         revision=$(svn info --show-item revision https or svn ://address...) 

svn command fails.
I inspected the reason and it seems the windows dll path is wrong.
so no svn commands will work inside scripts too.

@lazka
Copy link
Member

lazka commented Jul 30, 2023

works fine locally at least:

$ svn info --show-item revision https://svn.apache.org/repos/asf/subversion/trunk
1911359

@Zibri
Copy link
Author

Zibri commented Jul 30, 2023

It works in "bash" not inside the msys2 {0}.
All svn/svnversion commands in configure scripts fail because of this.
As a work-around I made an alias to "svn" and "svnversion" commands.

@lazka what do you mean locally?
it does work on windows installation.
it does not work on github actions.

@lazka
Copy link
Member

lazka commented Jul 30, 2023

I see, thanks.

Just to double check:

  • Did you install subversion with this action?
  • Could you go into more detail regarding your workaround?

@Zibri
Copy link
Author

Zibri commented Jul 30, 2023

Yes.. obvously subversion is installed.
I checked also opening a live shell... it's a dll problem (paths probably).
My workaround is for me only... not for "production"...
The solution is to change the PATHS (probably library paths)
My workaround was just to alias svn and svnversion with a curl onliner that gets the revision number.

@lazka
Copy link
Member

lazka commented Jul 30, 2023

Yes.. obvously subversion is installed.

Sorry, I wasn't clear. I was worried about the subversion that comes with GitHub Actions (https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md#tools) and this action could in theory be configured to keep the default GHA PATH intact (via the path-type option) and you end up using the wrong subversion.

My workaround was just to alias svn and svnversion with a curl onliner that gets the revision number.

I see, thanks

@Zibri
Copy link
Author

Zibri commented Jul 30, 2023

@lazka subversion inside bash on github actions works. It's the one in your msys2 that does not.. but it's not github fault... I think you just need to set the paths right. I can check that for you or we can do it together on a github special shell :D

@Zibri
Copy link
Author

Zibri commented Aug 2, 2023

I just found out 2 important things about msys2 and github actions:

  1. the problems above seem to involve only the latest 2 releases.
    these two are not affected.
    msys2-x86_64-20220128.exe
    msys2-x86_64-20230318.exe

  2. to add weirder to weird:
    in github windows-latest, if I use shell: bash
    and I do:

shell: bash
run: node -e 'const{spawn:spawn}=require("child_process"),bat=spawn("cmd.exe",["/c","setup.bat"]);bat.stdout.on("data",function(t){process.stdout.write(t)});'

I get a very different result than doing:

shell: cmd
run: setup.bat

setup.bat is:

curl -L "https://repo.msys2.org/distrib/x86_64/msys2-x86_64-20230318.exe" -o msysz.exe

msysz.exe install --root C:\msysz --confirm-command
c:\msysz\usr\bin\bash.exe --login -c "pacman -Suy --noconfirm"
c:\msysz\usr\bin\bash.exe --login -c "run_build_script.sh"

the first one (using a wrapper in nodejs that calls cmd.exe) makes everything work as on my windows pc.
the second one "sort of" works but gives all kind of problems.
I bet it's some environment variable
but I don't know enough to dig this more.

@Biswa96
Copy link
Member

Biswa96 commented Aug 3, 2023

Could you provide the project link which has that actions yaml file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants