Update Rust to 1.48 #6932

mati865 · 2020-09-04T08:30:47Z

mati865 · 2020-09-04T13:35:20Z

I can reproduce 64-bit (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION) locally with latest packages, trying to fix it.

Ouch:

(lldb) bt
* thread #1, stop reason = Exception 0xc0000005 encountered at address 0x2e74f7720: User-mode data execution prevention
(DEP) violation at location 0x2e74f7720
  * frame #0: 0x00000002e74f7720
    frame #1: 0x0000000277a9fe0b rustc_driver-dd6622bf73e2eb5a.dll`_$LT$rustc_driver..DEFAULT_HOOK$u20$as$u20$lazy_stati
c..LazyStatic$GT$::initialize::hd3a4f38e7904f614 + 231995
    frame #2: 0x0000000277ac17e0 rustc_driver-dd6622bf73e2eb5a.dll`rustc_driver::pretty::print_after_hir_lowering::hc6f4
c36ae1e9b344 + 4832
    frame #3: 0x0000000277a6614c rustc_driver-dd6622bf73e2eb5a.dll`rustc_driver::handle_options::he701fa99488a750e + 554
8
    frame #4: 0x0000000277a6720d rustc_driver-dd6622bf73e2eb5a.dll`rustc_driver::main::hd7e434be262eae6a + 45
    frame #5: 0x000000014000158e rustc.exe`rustc_binary::main::hb57cdd5e7952eb06 + 14
    frame #6: 0x0000000140001556 rustc.exe`std::rt::lang_start::_$u7b$$u7b$closure$u7d$$u7d$::he1d78f95d5162d84 + 6
    frame #7: 0x00000001e74f7d6d std-fc47a2c9bc2884a5.dll`std::rt::lang_start_internal::hbe42a3bca6615642 + 285
    frame #8: 0x00000001400015c8 rustc.exe`main + 56
    frame #9: 0x00000001400013c1 rustc.exe`__tmainCRTStartup at crtexe.c:335:15
    frame #10: 0x00000001400014f6 rustc.exe`mainCRTStartup at crtexe.c:219:9
    frame #11: 0x00007ffadeb86fd4 kernel32.dll`BaseThreadInitThunk + 20
    frame #12: 0x00007ffadfefcec1 ntdll.dll`RtlUserThreadStart + 33

abcfy2 · 2020-09-06T02:40:23Z

Hope this build failing would be fixed.

mati865 · 2020-09-07T10:31:18Z

I believe I've got the fix (still testing it to be sure).
Before rust-lang/rust#72049 Rust was relying on the linker "to make things work". That means linker to guess dllimport/dllexport and in case it fails the linker was using runtime pseudo relocs as backup.
I haven't full investigated it but I think the recent changes to Binutils (namely increasing base address over 4G for 64-bit binaries) made runtime pseudo relocs that have 32-bit offsets to overflow and hence trigger the DEP.
That would also explain why i686 build had no issues.

@lazka I believe that would explain some of those cases:

So far all software that also supports building with MSVC works fine (glib,gtk3,pygobject for example) so I'm wondering if this isn't just exposes some latent bugs for things only built with mingw so far. Agreed on the example search..

lazka · 2020-09-07T10:43:33Z

So we should pass -Wl,--no-dynamicbase,--image-base=0x400000 to revert this for rust for now?

mati865 · 2020-09-07T10:48:34Z

@lazka that would be complicated since executables and DLLs use different base addresses.
I'm backporting rust-lang/rust#72049 and it already passed with export LDFLAGS="-pipe". I'm testing default LDFLAGS now but since rust-lang/rust#75406 works for me locally I believe this will also succeed.

jeremyd2019 · 2020-09-07T21:19:10Z

@lazka that would be complicated since executables and DLLs use different base addresses.

Yes! I was considering sending another patch for binutils to allow selecting whether the default bases should be "high" or "low" via command line option. But I am not sold on that being a good idea. It would make hacking around buggy programs a lot easier though. Thoughts?

mati865 · 2020-09-07T21:32:39Z

It would make hacking around buggy programs a lot easier though. Thoughts?

It would definitely help with the transition.

msys2#6932 and msys2#6907 show packages have issues with the new default base addresses, so add an option to change back to the old defaults during the transition.

jeremyd2019 · 2020-09-07T23:03:48Z

It would definitely help with the transition.

I made a patch and am testing it now (simple tests worked as intended, going to attempt building GCC with it). I don't know if a 'transitional' option warrants upstreaming though.

lazka · 2020-09-12T17:39:19Z

New binutils with --default-image-base-low option is now in the repo.

mati865 · 2020-09-12T18:03:42Z

I think using rust-lang/rust#72049 instead of --default-image-base-low is better but it's up to you.

lazka · 2020-09-12T18:16:56Z

a real upstream fix/backport is obviously better

mati865 · 2020-09-28T09:46:37Z

I have no idea why CI fails on x86_64 build, lets try again.

lazka · 2020-10-14T22:26:58Z

Not sure if relevant, but it finds the wrong Python: -- Found Python3: C:/hostedtoolcache/windows/Python/3.8.6/x86/python.exe (found version "3.8.6") found components: Interpreter

mati865 · 2020-10-20T08:42:36Z

Blocked on #7116

mati865 · 2020-11-05T00:12:41Z

CI now appears to be failing due to path length but it's kinda hard to tell.

jeremyd2019 · 2020-11-05T00:35:45Z

Or command line length, by the look of that ar command... I copy/pasted it and saw 36618 characters there!

mati865 · 2020-11-05T07:33:12Z

I think it should have used response file but yeah sounds plausible.

filnet · 2020-11-17T18:01:47Z

Hi,

What's holding up the rust upgrade ? A hard to solve technical problem or just lack of time from the maintainers ?
Can I help in any way ?

mati865 · 2020-11-17T18:08:53Z

Local build succeeds every time for me.
I haven't got to dive deeply into the issue yet and since the next Rust version will be released this week I just decided to wait.

Zapeth · 2020-11-20T11:19:51Z

Looking at the build log it seems the failed ar command originates from compiling libgit2-sys for cargo.

I haven't heard yet of command line length being an issue when compiling any kind of software, but path length could certainly be an issue (some of those paths get pretty close to the Windows MAX_PATH length, and i686 config might just fall under that limit), though I'd be curious why this wasn't an issue with earlier package releases.

In any case, 1.48 was released yesterday, so it might be worth trying a new ci build with that.

mati865 · 2020-11-21T23:54:28Z

I haven't heard yet of command line length being an issue when compiling any kind of software, but path length could certainly be an issue

IIRC I have inspected the longest paths and they were under the limit. Command line limit is definitely a thing on Windows but it depends on how you run the executable so I won't even try to guess what is the limit in this case.

mati865 · 2020-11-22T12:01:53Z

I have no idea why it fails with rustc-1.48.0-src.tar.gz ... FAILED (unknown public key 85AB96E6FA1BE5FE) on CI.
The build passed for me locally before pushing.

lazka · 2020-11-22T12:03:59Z

It means the release was signed with an ancient gnupg which doesn't include the full key ID in the signature, so auto key retrieval doesn't work. You can remove the signature to avoid it.

msys2#6932 (comment)

Zapeth · 2020-11-22T16:51:50Z

Looks like the same issue. I did some searching online and found this -> rust-lang/cc-rs#496

To add some more context: The build.rs of libgit2-sys issues a cc::Build compile call which fails with the aforementioned error message, hopefully the problem will be fixed with that PR.

lazka · 2020-11-23T07:43:06Z

nice :) should I merge?

mati865 · 2020-11-23T08:33:18Z

I have made basic tests with x86_64 before pushing and it worked so I guess it's good to go.

lazka · 2020-11-23T08:45:03Z

thanks, I also built librsvg with it and all looks good.

Biswa96 · 2020-11-25T05:45:00Z

Just wait and watch.

mati865 force-pushed the update-rust branch from 5b03b18 to b3f1bd2 Compare September 4, 2020 08:33

mati865 mentioned this pull request Sep 4, 2020

Please upgrade rust to 1.45.2 #6758

Closed

mati865 marked this pull request as draft September 4, 2020 13:35

mati865 force-pushed the update-rust branch from b3f1bd2 to ba8a6aa Compare September 7, 2020 11:52

mati865 marked this pull request as ready for review September 7, 2020 11:52

mati865 force-pushed the update-rust branch from ba8a6aa to 4faa8c9 Compare September 7, 2020 13:07

mati865 mentioned this pull request Sep 7, 2020

gcc: DEP and ASLR not enabled by default #6674

Closed

jeremyd2019 mentioned this pull request Sep 8, 2020

gcc: specify LDFLAGS_FOR_TARGET and --with-boot-ldflags, disable dynamicbase for compiler #6907

Merged

mati865 mentioned this pull request Sep 14, 2020

gmp shared library consumers segfault when built with image base > 4GB, headers built for static lib #6983

Closed

lazka mentioned this pull request Sep 28, 2020

rust: Update to 1.46.0 #7044

Closed

mati865 force-pushed the update-rust branch from 4faa8c9 to 7acf419 Compare September 28, 2020 09:46

mati865 force-pushed the update-rust branch 2 times, most recently from b5f0661 to 2b0d14f Compare October 14, 2020 16:36

mati865 marked this pull request as draft October 14, 2020 16:36

mati865 changed the title ~~Update Rust to 1.46~~ Update Rust to 1.47 Oct 14, 2020

lazka force-pushed the update-rust branch from 1424185 to e6e7bcc Compare October 14, 2020 21:51

mati865 force-pushed the update-rust branch from e6e7bcc to 78d6915 Compare November 4, 2020 19:59

mati865 marked this pull request as ready for review November 4, 2020 20:04

mati865 force-pushed the update-rust branch from 78d6915 to 2277835 Compare November 4, 2020 20:10

mati865 force-pushed the update-rust branch from 2277835 to 24c23cd Compare November 21, 2020 23:50

mati865 changed the title ~~Update Rust to 1.47~~ Update Rust to 1.48 Nov 21, 2020

mati865 added 2 commits November 22, 2020 12:42

Update Rust to 1.48

3e1d8fb

Rust now default to single stage for builds

c26abb0

mati865 force-pushed the update-rust branch from 24c23cd to c26abb0 Compare November 22, 2020 11:42

Do not check the signature

5c60de3

msys2#6932 (comment)

Update cc crate to workaround command line length limit

2b8342e

lazka merged commit 6227cc8 into msys2:master Nov 23, 2020

mati865 deleted the update-rust branch November 23, 2020 08:56

ianks mentioned this pull request Jan 7, 2022

Add cargo builder for rust extensions rubygems/rubygems#5175

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Rust to 1.48 #6932

Update Rust to 1.48 #6932

mati865 commented Sep 4, 2020

mati865 commented Sep 4, 2020 •

edited

Loading

abcfy2 commented Sep 6, 2020

mati865 commented Sep 7, 2020

lazka commented Sep 7, 2020

mati865 commented Sep 7, 2020

jeremyd2019 commented Sep 7, 2020

mati865 commented Sep 7, 2020

jeremyd2019 commented Sep 7, 2020

lazka commented Sep 12, 2020

mati865 commented Sep 12, 2020

lazka commented Sep 12, 2020

mati865 commented Sep 28, 2020

lazka commented Oct 14, 2020

mati865 commented Oct 20, 2020

mati865 commented Nov 5, 2020

jeremyd2019 commented Nov 5, 2020 •

edited

Loading

mati865 commented Nov 5, 2020

filnet commented Nov 17, 2020

mati865 commented Nov 17, 2020

Zapeth commented Nov 20, 2020

mati865 commented Nov 21, 2020

mati865 commented Nov 22, 2020

lazka commented Nov 22, 2020 •

edited

Loading

Zapeth commented Nov 22, 2020 •

edited

Loading

lazka commented Nov 23, 2020

mati865 commented Nov 23, 2020

lazka commented Nov 23, 2020 •

edited

Loading

Biswa96 commented Nov 25, 2020

Update Rust to 1.48 #6932

Update Rust to 1.48 #6932

Conversation

mati865 commented Sep 4, 2020

mati865 commented Sep 4, 2020 • edited Loading

abcfy2 commented Sep 6, 2020

mati865 commented Sep 7, 2020

lazka commented Sep 7, 2020

mati865 commented Sep 7, 2020

jeremyd2019 commented Sep 7, 2020

mati865 commented Sep 7, 2020

jeremyd2019 commented Sep 7, 2020

lazka commented Sep 12, 2020

mati865 commented Sep 12, 2020

lazka commented Sep 12, 2020

mati865 commented Sep 28, 2020

lazka commented Oct 14, 2020

mati865 commented Oct 20, 2020

mati865 commented Nov 5, 2020

jeremyd2019 commented Nov 5, 2020 • edited Loading

mati865 commented Nov 5, 2020

filnet commented Nov 17, 2020

mati865 commented Nov 17, 2020

Zapeth commented Nov 20, 2020

mati865 commented Nov 21, 2020

mati865 commented Nov 22, 2020

lazka commented Nov 22, 2020 • edited Loading

Zapeth commented Nov 22, 2020 • edited Loading

lazka commented Nov 23, 2020

mati865 commented Nov 23, 2020

lazka commented Nov 23, 2020 • edited Loading

Biswa96 commented Nov 25, 2020

mati865 commented Sep 4, 2020 •

edited

Loading

jeremyd2019 commented Nov 5, 2020 •

edited

Loading

lazka commented Nov 22, 2020 •

edited

Loading

Zapeth commented Nov 22, 2020 •

edited

Loading

lazka commented Nov 23, 2020 •

edited

Loading