From a59908ad4ea5875775fa2ce2cff0f611d4761f99 Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Wed, 22 Nov 2023 10:24:37 +0100 Subject: [PATCH] Remove QuicStreamChannel.WRITE_FIN (#620) Motivation: QuicStreamChannel.WRITE_FIN was deprecated a long time ago. Let's remove it as this release will contain another breaking change anyway. Modifications: Remove QuicStreamChannel.WRITE_FIN Result: Cleanup --- .../incubator/codec/quic/QuicStreamChannel.java | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/codec-classes-quic/src/main/java/io/netty/incubator/codec/quic/QuicStreamChannel.java b/codec-classes-quic/src/main/java/io/netty/incubator/codec/quic/QuicStreamChannel.java index c259cec7d..9f53f0cf7 100644 --- a/codec-classes-quic/src/main/java/io/netty/incubator/codec/quic/QuicStreamChannel.java +++ b/codec-classes-quic/src/main/java/io/netty/incubator/codec/quic/QuicStreamChannel.java @@ -28,26 +28,11 @@ */ public interface QuicStreamChannel extends DuplexChannel { - /** - * Should be added to a {@link ChannelFuture} when the {@code FIN} should be sent to the remote peer and no more - * writes will happen. - * - * Important: The FIN will not be propagated through the {@link io.netty.channel.ChannelPipeline} - * to make it easier to reuse this {@link ChannelFutureListener} with all kind of different handlers that sit on top - * of {@code QUIC}. If you want to ensure the {@code FIN} is propagated through the - * {@link io.netty.channel.ChannelPipeline} as a write just write a {@link QuicStreamFrame} directly with the - * {@code FIN} set. - * - * @deprecated use {@link #SHUTDOWN_OUTPUT} - */ - @Deprecated - ChannelFutureListener WRITE_FIN = f -> ((QuicStreamChannel) f.channel()).shutdownOutput(); - /** * Should be added to a {@link ChannelFuture} when the output should be cleanly shutdown via a {@code FIN}. No more * writes will be allowed after this point. */ - ChannelFutureListener SHUTDOWN_OUTPUT = WRITE_FIN; + ChannelFutureListener SHUTDOWN_OUTPUT = f -> ((QuicStreamChannel) f.channel()).shutdownOutput(); @Override default ChannelFuture bind(SocketAddress socketAddress) {