Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README updates? #249

Open
djc opened this issue Jun 7, 2024 · 1 comment
Open

README updates? #249

djc opened this issue Jun 7, 2024 · 1 comment

Comments

@djc
Copy link

djc commented Jun 7, 2024

Following up on https://phanpy.social/#/hachyderm.io/s/112571606961741408, the root README.md has:

samply works on macOS and Linux. Windows support is planned.

But the samply crate README.md has:

At the moment, the macOS implementation works best. The Linux implementation is extremely new and experimental. There is no Windows implementation yet.

Per the Mastodon response from @jrmuizel, both of these might not be up to date? I would suggest maybe merging the README's so you don't forget to make updates to both? (The crate-level one gets shown on crates.io.)

Might also want to keep https://nnethercote.github.io/perf-book/profiling.html up to date.

I think samply is great, have been it using this week on rustup, thanks for building it! (It is dampening my motivation for maintaining cargo-flamegraph, so will try to make sure to point it out to people.)

@djc
Copy link
Author

djc commented Jun 7, 2024

Added this in the flamegraph README:

Screenshot 2024-06-07 at 12 01 44

PRs with more accurate/extensive information welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant