Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AzureAppGatewayAnalytics and fixing Firewall issue #199

Merged
merged 4 commits into from
May 17, 2021
Merged

AzureAppGatewayAnalytics and fixing Firewall issue #199

merged 4 commits into from
May 17, 2021

Conversation

v-fearam
Copy link
Contributor

AzureAppGatewayAnalytics was not working.
Fixing Firewall rules
Deleting useless firewall rules
Adding a dependency to avoid random issue

@v-fearam v-fearam requested a review from ckittel May 17, 2021 12:10
ckittel
ckittel requested changes May 17, 2021
View reviewed changes
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good except for the open question I have on base policy name now including a region name

networking/hub-default.json Outdated Show resolved Hide resolved
ckittel
ckittel approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@v-fearam v-fearam merged commit f51d8d4 into main May 17, 2021
@v-fearam v-fearam deleted the fix/AzureAppGatewayAnalytics branch May 17, 2021 16:06
@ckittel ckittel mentioned this pull request Sep 17, 2021
Closed
@ckittel ckittel mentioned this pull request Sep 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckittel ckittel ckittel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-fearam @ckittel