Allow parameters in custom test functions #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert query({'val': 5}) | ||
| assert not query({'val': 0}) | ||
| assert not query({'val': 11}) | ||
| assert not query({'val': '44'}) |
There was a problem hiding this comment.
You're using a string for 44, not an int. This breaks the tests for Python3 and PyPy3 (see https://travis-ci.org/msiemens/tinydb/builds/68895961).
|
There's a tiny mistake in a test, but otherwise it looks good! |
|
Should I just remove that test? I only included the string comparison because there was a similar one for the previous test case. |
|
Ahh, I see the issue now. I'll simply remove the test. |
lordjabez
force-pushed
the
feature/arbitrary-parameters-for-custom-test
branch
from
235902d
to
9f55011
Compare
msiemens
added a commit
that referenced
this pull request
Jul 4, 2015
…r-custom-test Allow parameters in custom test functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address issue #63.