Strange output on Windows

[itavero]

I'm getting the following output on Windows (both in Command Prompt, as well as in Git Bash). Looks like I'm missing something?

F←[0me←[0mt←[0mc←[0mh←[0mi←[0mn←[0mg←[0m ←[0mo←[0mr←[0mi←[0mg←[0mi←[0mn←[0m
←[0m←[0m←[1mdevelop     ←[0m←[0m ←[0m←[32mup to date←[0m←[0m
←[0mfeature/528 ←[0m←[0m ←[0m←[32mup to date←[0m←[0m
←[0mfeature/551 ←[0m←[0m ←[0m←[32mup to date←[0m←[0m
←[0mfeature/575 ←[0m←[0m ←[0m←[32mup to date←[0m←[0m
←[0mhotfix/545  ←[0m←[0m ←[0m←[32mup to date←[0m←[0m
←[0mhotfix/580  ←[0m←[0m ←[0m←[32mup to date←[0m←[0m
←[0mThe system cannot find the path specified.
←[0m

[msiemens]

Strange... Which version of Windows are you using? And which version of PyGitUp?

[itavero]

I'm using Windows 7 (x64, Service Pack 1), with Python 2.7.8. GitUp is at version v1.3.0.

[pampersrocker]

Same Problem

• Windows 8.1
• Cygwin 64
• Oh-My-Zsh
• Python 3.4.3
• PyGitUp 1.3.0

[msiemens]

I can now reproduce this behaviour. Will investigate...

[msiemens]

Looks like it's a regression of some kind in colorama introduced in tartley/colorama@961428e. I'm not sure what the right fix is here (besides downgrading the dependency). Could you both run echo %TERM% (in bash it's echo $TERM of course) in your consoles and report the result here?

[pampersrocker]

echo $TERM returns cygwin. On the default windows command line TERM is not set:

(Also wrong output on windows command line:)

[msiemens]

For now we'll have to live with a workaround. Could you try the latest dev version (pip install git+https://github.com/msiemens/PyGitUp.git) and report whether it actually fixes the bug?

[Predelnik]

It seems like it's still the same for me with dev version, also I suggest to add an option to disable coloring entirely since it would be useful not only in that case but to help users annoyed by colors 😄

[msiemens]

Okay, this is getting really interesting. For reference, the latest dev version fixed this on my computer.

@Predelnik Could you uninstall PyGitUp and then reinstall the dev version to make sure?

[Predelnik]

Yeah reinstalling seems to fix this issue, I'm not very active user of pip so didn't know that it may be required sorry.

Though there's some leftover ←[0m at the bottom I don't know if it's intended

[msiemens]

Yeah, I noticed the ←[0m too. Will investigate this soon.

[msiemens]

I've filed an issue in colorama (which is responsible for converting ANSI codes to Win32 calls): tartley/colorama#49

[pampersrocker]

(Just for info you need to add --upgrade to the pip call to update the existing version. Instead of manually uninstalling)

Yes I can confirm the the latest dev version fixes the colors, just as @Predelnik said the ←[0m is left.

[msiemens]

Is that still an issue with PyGitUp 1.4.0?

[hugovk]

Looks fixed for me: cmd.exe and MINGW32 are much improved and have switched the [0m← stuff for colours.

But Git Bash (MINGW64) has lost its colours. I've made a new issue for this different problem: #48.

[msiemens]

Okay, we'll track that on the issue you've opened.