Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead-letter on crash #5

Open
bergie opened this issue Jan 3, 2016 · 2 comments
Open

Dead-letter on crash #5

bergie opened this issue Jan 3, 2016 · 2 comments

Comments

@bergie
Copy link
Member

bergie commented Jan 3, 2016

Currently if the Node.js process segfaults, the connection is not closed. Once AMQP decides that it is dead, the message that caused a segfault is requeued. In many cases this will cause another worker to crash. Then another, until all are dead.

Would be better to dead-letter in this case.

@jonnor
Copy link
Member

jonnor commented Jan 6, 2016

It looks like our best bet is to use the redelivered tag, and then NACK (requeue=false) the message (or route it differently).
http://stackoverflow.com/questions/17654475/consuming-not-acknowledge-messages-from-rabbitmq

However, redelivery can happen because of several reason. A channel close due to being scaled down (which is expected and happens a lot with guv) will requeue just like a crash will.

So deadlettering is basically mandatory then. So maybe we should only enable this behavior for --deadletter queues.

@bergie
Copy link
Member Author

bergie commented Jul 6, 2016

@jonnor would be good to bump this in priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants