-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing min/max on textfield #99
Comments
this isn't difficult to add. Did i mention, that this project is open for pull requests? :) |
Sure. :) Not quite sure how it should work tho... Max/min is only allowed if type is number. Should I create another *ngIf just for this purpose? |
i would suggest do not any special logic. just propagate the attribute from the wrapper element down to the input element and let the browser implementation/angular do the rest (like it was implemented for name or placeholder). |
I can't test it atm, but hope this helps: |
@simonschllng Feel free to create a PR if you already have a patch. I've been quite busy lately and haven't had the time to do so. |
@simonschllng Thanks for your help! |
Min/max attributes are missing in textfield with type number.
See https://jsfiddle.net/hv28yrfv/1/
The text was updated successfully, but these errors were encountered: