Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special Characters are not Invalidated Before Transmission #102

Open
MaximilianKoestler opened this issue Apr 18, 2018 · 0 comments
Open

Comments

@MaximilianKoestler
Copy link

My bank sometimes issues dialog ids starting with a + sign.

The dialog id in the bank's response then looks like this:

HNHBK: ... +?+ABCDEFGHIJK ... (Bank -> fints-hbci-php)

As you can see, the + is escaped (invalidated) with a prefix ? in the message from the bank.
However, once this id gets used by fints-hbci-php in the next message, it is not properly escaped.

Therefore, two consecutive + signs occur in the message which gets rejected by the bank:

HNHBK: ... ++ABCDEFGHIJK ... (fints-hbci-php -> Bank)

when it should send:

HNHBK: ... +?+ABCDEFGHIJK ... (fints-hbci-php -> Bank)

I have fixed this on my end in the Dialog.php during the initial processing of the dialog id.

This is obviously not the proper place to put this fix, since it might also be relevant for other message elements.
When I tried a simple fix in the AbstractSegment.php I broke some parts because I apparently also escaped + signs that I should not have, but I currently have no time for a deeper investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant