From b3e7ac2605c18c041293cd3ab892c963e1145176 Mon Sep 17 00:00:00 2001
From: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Date: Sat, 20 Aug 2016 08:23:28 +0530
Subject: [PATCH] util: improve function signature of util._extend
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The function signature of `util._extend` is not intuitive and the
documentation doesn't specify the necessary second parameter. This
patch changes the parameter names in the code and the function params
in doc.

PR-URL: https://github.com/nodejs/node/pull/8187
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
---
 doc/api/util.md |  2 +-
 lib/util.js     | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/doc/api/util.md b/doc/api/util.md
index 6b6514debc820f..ce8812adbf3855 100644
--- a/doc/api/util.md
+++ b/doc/api/util.md
@@ -812,7 +812,7 @@ deprecated: v0.11.3
 
 Deprecated predecessor of `console.log`.
 
-### util.\_extend(obj)
+### util.\_extend(target, source)
 <!-- YAML
 added: v0.7.5
 deprecated: v6.0.0
diff --git a/lib/util.js b/lib/util.js
index b4ff85f9a6edb1..245b19639324df 100644
--- a/lib/util.js
+++ b/lib/util.js
@@ -983,16 +983,16 @@ exports.inherits = function(ctor, superCtor) {
   Object.setPrototypeOf(ctor.prototype, superCtor.prototype);
 };
 
-exports._extend = function(origin, add) {
-  // Don't do anything if add isn't an object
-  if (add === null || typeof add !== 'object') return origin;
+exports._extend = function(target, source) {
+  // Don't do anything if source isn't an object
+  if (source === null || typeof source !== 'object') return target;
 
-  var keys = Object.keys(add);
+  var keys = Object.keys(source);
   var i = keys.length;
   while (i--) {
-    origin[keys[i]] = add[keys[i]];
+    target[keys[i]] = source[keys[i]];
   }
-  return origin;
+  return target;
 };
 
 function hasOwnProperty(obj, prop) {