Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

Concurrency mode: optimistic auto generated Timestamp property #35

Closed
dcastenholz opened this issue Nov 8, 2018 · 4 comments
Closed
Labels
bug Confirmed bug released Issue is resolved in a current release

Comments

@dcastenholz
Copy link

2 separate, yet related bugs:

  1. When Concurrency is set to optimistic, and no property is marked as "Is Concurrency Token", the extension automatically creates a working Timestamp property, but the extension throws an error saying: "Entity1: Should have 1 concurrency properties but has 0".

  2. If you add a property and then mark it as "Is Concurrency Token" = True, the generated property has [Required] on it which causes validation errors on save. The UI does not allow you to change the Required = True setting.

@msawczyn msawczyn added the investigating Looking into this label Nov 12, 2018
@dcastenholz
Copy link
Author

Not trying to complicate things, but maybe Timestamp and ConcurrencyCheck should be separated. The auto-generated Timestamp works well other than the extraneous error that is generated by the extension. Build and functionality are both fine. Workaround is to just ignore the error.

@msawczyn
Copy link
Owner

That'll be fixed in the next version. Thanks for pointing it out.

@msawczyn msawczyn added the bug Confirmed bug label Nov 26, 2018
@msawczyn
Copy link
Owner

This was a tricky one, philosophically, to deal with. In the best of all worlds, the designer and the code generation are separate. Yet the designer should know that the concurrency property will be automatically generated and not give the error. While not the best of all solutions, I've removed the error message, and that change is available in v1.2.6.18.

@msawczyn msawczyn added released Issue is resolved in a current release and removed investigating Looking into this labels Nov 27, 2018
@msawczyn
Copy link
Owner

Closing since fix is now released

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Confirmed bug released Issue is resolved in a current release
Projects
None yet
Development

No branches or pull requests

2 participants