More useful colors, Bootstrap convention and compatibility #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I am very happy to use this repo during recent months and I really thank you for that. I usually tend to use CDN links but at the same time I like to have more options in terms of customisation. Therefore, I was wondering if I could be contributing to this repo and then have a better customised CDN. These are my changes to the repo and I hope they will be ok.
Beautiful colors are added from "persian" family.
Some branding colors (facebook, ...) are added since they are widely seen by the users and present a sense of intimacy. These new colors also bring simplicity in UI design. Blue variation has been point of concern as it is regarded as peaceful, tranquil, secure, and orderly.
Since this css will be probably used as a complementary color palette to Bootstrap framework (as I usually do), some css classes have been renamed to be consistent with bootstrap conventions introducing more integrity in coding (.{color} -> .text-{color} & .border--{color} -> .border-{color}).
As this css color palette can be used individually, bootstrap colors (primary, secondary , ...) are also introduced providing a wide range of options in hand.
"!important" declaration is added to provide specificity.
Feel free to edit in case of need.
Regards
Meysam Majnooni