This repository has been archived by the owner on Aug 27, 2020. It is now read-only.
forked from python-babel/flask-babel
-
Notifications
You must be signed in to change notification settings - Fork 18
Merging Flask-BabelEx back into Flask-Babel #20
Comments
I am totally fine merging into the flask-babel. Originally this fork started as a merge request against baseline flask-babel, but Armin decided to not merge it for some reason and I don't remember what it was back then. Anyway, if flask-babel maintainer(s) are willing to merge dynamic translation domains into the mainline repo - I can definitely deprecate the fork and switch flask-admin to use flask-babel. |
@mitsuhiko do you remember the reason for not merging the changes upstream? |
I don't have a recollection of anything. |
Sorry, closed by an accident. |
We just created a PR for it; a review from you @mrjoes would be appreciated! (also, in case it didn't ping you, there's a question for you in the PR's description) |
This is now live with version 2.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
After some discussions in the Pallets discord (where people, including myself, actually assumed that BabelEx is dead due to not having had a release in the last 4 years), I'm wondering whether it wouldn't make sense to merge back the changes from Flask-BabelEx into Flask-Babel.
As the lead developer of a project that currently uses Flask-BabelEx and the extra features it has, I'd love to see that happen (since actively maintained libs are nicer to work with, and for something as "core" as i18n having one single lib would make things more straightforward for anyone).
We can actually dedicate some developer time for this, but it would be interesting to hear your opinion on that as well, @mrjoes, since you started the fork in the first place.
The text was updated successfully, but these errors were encountered: