Skip to content
This repository has been archived by the owner on Aug 27, 2020. It is now read-only.

Merging Flask-BabelEx back into Flask-Babel #20

Closed
ThiefMaster opened this issue Feb 10, 2020 · 6 comments
Closed

Merging Flask-BabelEx back into Flask-Babel #20

ThiefMaster opened this issue Feb 10, 2020 · 6 comments

Comments

@ThiefMaster
Copy link

After some discussions in the Pallets discord (where people, including myself, actually assumed that BabelEx is dead due to not having had a release in the last 4 years), I'm wondering whether it wouldn't make sense to merge back the changes from Flask-BabelEx into Flask-Babel.

As the lead developer of a project that currently uses Flask-BabelEx and the extra features it has, I'd love to see that happen (since actively maintained libs are nicer to work with, and for something as "core" as i18n having one single lib would make things more straightforward for anyone).

We can actually dedicate some developer time for this, but it would be interesting to hear your opinion on that as well, @mrjoes, since you started the fork in the first place.

@mrjoes
Copy link
Owner

mrjoes commented Feb 11, 2020

I am totally fine merging into the flask-babel. Originally this fork started as a merge request against baseline flask-babel, but Armin decided to not merge it for some reason and I don't remember what it was back then.

Anyway, if flask-babel maintainer(s) are willing to merge dynamic translation domains into the mainline repo - I can definitely deprecate the fork and switch flask-admin to use flask-babel.

@ThiefMaster
Copy link
Author

@mitsuhiko do you remember the reason for not merging the changes upstream?

@mitsuhiko
Copy link

I don't have a recollection of anything.

@mrjoes mrjoes closed this as completed Feb 11, 2020
@mrjoes mrjoes reopened this Feb 11, 2020
@mrjoes
Copy link
Owner

mrjoes commented Feb 11, 2020

Sorry, closed by an accident.

@ThiefMaster
Copy link
Author

ThiefMaster commented Feb 13, 2020

We just created a PR for it; a review from you @mrjoes would be appreciated! (also, in case it didn't ping you, there's a question for you in the PR's description)

@TkTech
Copy link

TkTech commented Aug 27, 2020

This is now live with version 2.0.

@mrjoes mrjoes closed this as completed Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants