Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C125 doesn't seem to take negative positions via file #667

Closed
dfinberg opened this issue Jan 23, 2023 · 2 comments
Closed

C125 doesn't seem to take negative positions via file #667

dfinberg opened this issue Jan 23, 2023 · 2 comments
Labels
bug: Confirmed Something isn't working, the bug was confirmed.

Comments

@dfinberg
Copy link

Describe the bug
I'm attempting to use the C125 custom gcode command, but it won't allow me to set the X position to -20 via a gcode.

To Reproduce
Steps to reproduce the behavior:
Use a custom gcode command to set a negative X offset (within the system dimensions) and it is returning 0.
M503
...
Recv: echo:; Physical minimums:
Recv: echo: C100 X-20 Y0
Recv: echo:; Physical maximums:
Recv: echo: C101 X310 Y310 Z320
Recv: echo:; Bed size:
Recv: echo: C102 X300 Y300
...

Send: C125 X-20 Y0 Z20
Recv: echo:; Park Head:
Recv: echo: C125 X0 Y0 Z20
Recv: ok P15 B15
[...]

sent via octoprint, but same results via custom config file.

It does allow me to set it via the advanced/physical/park menu.

Expected behavior
Should allow the offset.

Version (please complete the following information):
422 latest release, as well as DACAI display test binary.
Send: C115
Recv: Marlin ProUI 2.1.3 MRiscoC
Recv: Build: 20230122 - 02:49
Recv: Author: Miguel A. Risco-Castillo (MRiscoC)
@mriscoc mriscoc added the bug: Confirmed Something isn't working, the bug was confirmed. label Jan 23, 2023
mriscoc added a commit that referenced this issue Mar 12, 2023
@mriscoc
What's new in Boreal Spring 20230312 version
314835d 
- Fix #742
- Increased the number of sorted files to 50
- Preview works in DWIN and DACAI screens (selected automatically, S1 F4 preview supports only DACAI screens in the precompiled firmware)
- Fix C125 issue: #667
- Power outage recovery can be enabled/disabled in tune menu
- Improved power outage recovery
- Added Extrude 100 mm to Move menu for aid with extruder calibration
- Optimize print percent and remain time to use Marlin's processing
- Decrease HOTEND_IDLE_MIN_TRIGGER to 150
- Removed forcing automatic cool down and motor disable
- Axes are not immediately disabled after abort print, now using timeout.
- Allows enable/disable file list sorting if MEDIASORT_MENU_ITEM is defined
- Enable/Disable tune menu items: RUNOUT_TUNE_ITEM, PLR_TUNE_ITEM, JD_TUNE_ITEM, ADVK_TUNE_ITEM
- Use LCD_BED_TRAMMING settings for bed tramming
- Some fixes in source code for special configurations
- Several minor fixes
- Marlin'sFix UBL 'G29 J' mesh tilt (#25453)
- Marlin's Enhanced IS and LA
- Marlin's Fix FastPWM calculations (#25343)
- Marlin's AVOID_OBSTACLES for UBL (#25256)
- and many more fixes from latest Marlin's bugfix 2.1.x
@mriscoc
Copy link
Owner

mriscoc commented Mar 13, 2023

Fixed in latest version

@mriscoc mriscoc closed this as completed Mar 13, 2023
mattcoon added a commit to mattcoon/Ender3V2S1 that referenced this issue Mar 20, 2023
@mattcoon
Squashed commit of the following:
df01f28 
commit 314835d
Author: Miguel Risco-Castillo <[email protected]>
Date:   Sun Mar 12 17:11:56 2023 -0500

    What's new in Boreal Spring 20230312 version
    - Fix mriscoc#742
    - Increased the number of sorted files to 50
    - Preview works in DWIN and DACAI screens (selected automatically, S1 F4 preview supports only DACAI screens in the precompiled firmware)
    - Fix C125 issue: mriscoc#667
    - Power outage recovery can be enabled/disabled in tune menu
    - Improved power outage recovery
    - Added Extrude 100 mm to Move menu for aid with extruder calibration
    - Optimize print percent and remain time to use Marlin's processing
    - Decrease HOTEND_IDLE_MIN_TRIGGER to 150
    - Removed forcing automatic cool down and motor disable
    - Axes are not immediately disabled after abort print, now using timeout.
    - Allows enable/disable file list sorting if MEDIASORT_MENU_ITEM is defined
    - Enable/Disable tune menu items: RUNOUT_TUNE_ITEM, PLR_TUNE_ITEM, JD_TUNE_ITEM, ADVK_TUNE_ITEM
    - Use LCD_BED_TRAMMING settings for bed tramming
    - Some fixes in source code for special configurations
    - Several minor fixes
    - Marlin'sFix UBL 'G29 J' mesh tilt (#25453)
    - Marlin's Enhanced IS and LA
    - Marlin's Fix FastPWM calculations (#25343)
    - Marlin's AVOID_OBSTACLES for UBL (#25256)
    - and many more fixes from latest Marlin's bugfix 2.1.x

commit 398d931
Author: Miguel Risco-Castillo <[email protected]>
Date:   Sun Mar 12 12:54:13 2023 -0500

    Prepare repository
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug: Confirmed Something isn't working, the bug was confirmed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mriscoc @dfinberg