Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Compilation error when disabling LCD_BACKLIGHT_TIMEOUT_MINS #1209

Closed
Abasz opened this issue Jan 9, 2024 · 4 comments
Closed

[BUG] Compilation error when disabling LCD_BACKLIGHT_TIMEOUT_MINS #1209

Abasz opened this issue Jan 9, 2024 · 4 comments
Labels
bug: Confirmed Something isn't working, the bug was confirmed.

Comments

@Abasz
Copy link

Abasz commented Jan 9, 2024

Did you test with a precompiled firmware?

Yes, and the problem still exists.

Bug Description

When I do my custom build with the most current (New Year 2024 (20240107)) version I get compilation error when I disable (comment out) the LCD_BACKLIGHT_TIMEOUT_MINS variable:

.platformio/packages/toolchain-gccarmnoneeabi/bin/../lib/gcc/arm-none-eabi/12.3.1/../../../../arm-none-eabi/bin/ld.exe: Marlin/lib/proui\libproui.a(meshviewerpro.cpp.o): in function
MeshViewerPro::drawPoint(unsigned char, unsigned char, float)': (.text._ZN13MeshViewerPro9drawPointEhhf+0xb8): undefined reference to MarlinUI::refresh_backlight_timeout()'

EDIT:

Note that I tested the compilation with the default settings included in the Marlin folder (i.e. not with my custom build) and have only the LCD_BACKLIGHT_TIMEOUT_MINS commented out. Compilation still fails with the same error.

Bug Timeline

Issue starts with 20230905 and occurs for every build. Actually before this version the default was that its commented out.

EDIT, slight correction: 20230805 compiles fine when LCD_BACKLIGHT_TIMEOUT_MINS is disabled.

Expected behavior

I expect no compilation error

Actual behavior

The following compilation error

.platformio/packages/toolchain-gccarmnoneeabi/bin/../lib/gcc/arm-none-eabi/12.3.1/../../../../arm-none-eabi/bin/ld.exe: Marlin/lib/proui\libproui.a(meshviewerpro.cpp.o): in function
MeshViewerPro::drawPoint(unsigned char, unsigned char, float)': (.text._ZN13MeshViewerPro9drawPointEhhf+0xb8): undefined reference to MarlinUI::refresh_backlight_timeout()'

Steps to Reproduce

Comment out the LCD_BACKLIGHT_TIMEOUT_MINS in Configuration_adv.h
Start compilation

Version of Professional Firmware

20240107

Printer model

ender 3v2

Electronics

SKR mini

LCD/Controller

Dwin

Other add-ons

No response

Bed Leveling

UBL Bilinear mesh

Your Slicer

Cura

Host Software

SD Card (headless)

Additional information & file uploads

No response

@Abasz Abasz added the Bug: Potential ? Is it a bug? confirmation or more user feedback is required label Jan 9, 2024
@mf7120
Copy link

mf7120 commented Jan 9, 2024

I can confirm this used to happen to me when trying to save some space in the F4 chip in the E3S1. So it is indeed a bug.

@TheWebMachine
Copy link

Agreed. Also some [read: my] F4 boards can even lock up if you attempt to turn brightness to 0, like I once tried in start Gcode for Octoprint prints. Within a couple minutes of the brightness getting turned to 0, the board would lock up. I wonder if they are powering some part of the LCD logic off of the backlight power or tied to it somehow, such that when it goes all the way to zero, comms to the board are interrupted. The F4 is definitely finicky about anything involving the LCD.

@mriscoc mriscoc added bug: Confirmed Something isn't working, the bug was confirmed. and removed Bug: Potential ? Is it a bug? confirmation or more user feedback is required labels Jan 10, 2024
@Abasz
Copy link
Author

Abasz commented Jan 11, 2024

I confirm this is working with my config. Thanks for the prompt help.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Apie56 pushed a commit to Apie56/Ender-3-V2-Mrisco that referenced this issue Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug: Confirmed Something isn't working, the bug was confirmed.
Projects
None yet
Development

No branches or pull requests

4 participants