Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change SqlVar::type to enum #124

Closed
GitMensch opened this issue Aug 31, 2022 · 2 comments
Closed

change SqlVar::type to enum #124

GitMensch opened this issue Aug 31, 2022 · 2 comments
Labels
enhancement New feature or request ready
Milestone

Comments

@GitMensch
Copy link
Contributor

Along with enum SqlVarType SqlVar::getType() and std::vector<enum SqlVarType> param_types; - cast to/from int where absolute necessary - but keep as enum wherever possible.

This would ease debugging and for some places may provide type safety, too.

@mridoni mridoni added the enhancement New feature or request label Nov 9, 2022
@mridoni
Copy link
Owner

mridoni commented Nov 9, 2022

This, among other things, is an holdover from the C/ocesql roots of GixSQL, there are also a few places where pointer lists are passed as int * plus an additional int for length, instead of something like const std::vector<int>& (or string). This needs to change, for all the reasons you enumerated.

@mridoni
Copy link
Owner

mridoni commented Jan 3, 2023

This is already in https://github.com/mridoni/gixsql/tree/v1.0.20dev. I am not closing the issue until the branch is merged into main.

@mridoni mridoni added the ready label Jan 3, 2023
@mridoni mridoni closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

No branches or pull requests

2 participants