fix: only reset esbuild bin path if it was overwritten (#190)

mrgrain · Jul 15, 2022 · 59c3c80 · 59c3c80
1 parent 31ef196
commit 59c3c80
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/bundler.ts b/src/bundler.ts
@@ -195,7 +195,13 @@ export class EsbuildBundler {
           printBuildMessages(error as BuildFailure, { prefix: 'Build ' });
         }
 
-        process.env.ESBUILD_BINARY_PATH = originalEsbuildBinaryPath;
+        /**
+         * only reset `ESBUILD_BINARY_PATH` if it was explicitly set via the construct props
+         * since `esbuild` itself sometimes sets it (eg. when running in yarn 2 plug&play)
+         */
+        if (this.props.esbuildBinaryPath) {
+          process.env.ESBUILD_BINARY_PATH = originalEsbuildBinaryPath;
+        }
 
         return true;
       },