Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing orjson jsonlines export #116

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Fixing orjson jsonlines export #116

merged 1 commit into from
Jun 8, 2023

Conversation

dchaplinsky
Copy link
Collaborator

No description provided.

@dchaplinsky dchaplinsky requested a review from mrgambal June 8, 2023 09:38
@dchaplinsky
Copy link
Collaborator Author

From the documentation:
To migrate from the standard library, the largest difference is that orjson.dumps returns bytes and json.dumps returns a str

Do not use os.linesep as a line terminator when writing files opened in text mode (the default); use a single '\n' instead, on all platforms.

@dchaplinsky dchaplinsky merged commit 28ff02e into master Jun 8, 2023
@dchaplinsky
Copy link
Collaborator Author

Could you please bump the version and do the release?

@mrgambal mrgambal deleted the hotfix/orjson_bytes branch June 8, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgambal mrgambal mrgambal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dchaplinsky @mrgambal