Implement support for texture matrix for uv2 #18099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, we only supported one texture matrix for the material that was applied to uv data based on the first texture, in priority order, that needed it. This change adds equivalent support for uv2 - we now transform second UV channel with a second UV transform that is grabbed from aoMap or lightMap (that are the only two textures using it atm). This fixes glTF rendering for files that use KHR_texture_transform on the occlusion texture, including ones produced by gltfpack.
|
Thanks! |
|
Oops I didn't notice the lint whitespace error; would you like me to open another PR to fix this? |
|
Oh never mind, you've fixed this in dev :) Thanks! Sorry about that. |
|
It's all good! :D |
|
FYI 2332bfd |
|
The docs need to be updated, too. |
|
Thanks! I didn't realize the docs called this out specifically. Submitted #18102. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, we only supported one texture matrix for the
material that was applied to uv data based on the first texture, in
priority order, that needed it.
This change adds equivalent support for uv2 - we now transform second UV
channel with a second UV transform that is grabbed from aoMap or
lightMap (that are the only two textures using it atm).
This fixes glTF rendering for files that use KHR_texture_transform on
the occlusion texture, including ones produced by gltfpack.
Fixes #18088.