Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GLTFExporter to jsm #15977

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Update GLTFExporter to jsm #15977

merged 1 commit into from
Mar 15, 2019

Conversation

garyo
Copy link
Contributor

@garyo garyo commented Mar 14, 2019

I need to export GLTF, so here's a PR to convert examples/js/exporters/GLTFExporter.js to JSM. I followed the style and form of GLTFLoader, and it seems to work OK for me.

@mrdoob mrdoob added this to the r103 milestone Mar 15, 2019
@mrdoob mrdoob merged commit dd5a42c into mrdoob:dev Mar 15, 2019
@mrdoob
Copy link
Owner

mrdoob commented Mar 15, 2019

Thanks!

@mrdoob mrdoob mentioned this pull request Mar 15, 2019
Closed
@garyo
Copy link
Contributor Author

garyo commented Mar 15, 2019

Thanks! I converted this by hand but now I see there's an automated process (looks like it's cd examples; node ../utils/modularize.js); I'll use that in future.

@garyo garyo deleted the feature/gltf-exporter-jsm branch April 19, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r103
Development

Successfully merging this pull request may close these issues.
2 participants
@garyo @mrdoob