Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSM: Adding GLTFExporter as a module in examples/jsm/exporters #15899

Closed
wants to merge 1 commit into from
Closed

JSM: Adding GLTFExporter as a module in examples/jsm/exporters #15899

wants to merge 1 commit into from

Conversation

codlaug
Copy link

@codlaug codlaug commented Mar 4, 2019

I ran modularize.js on examples/js/exporters/GLTFExporter.js and made a few minor changes to get it to export correctly in my ES6 environment.

Also made one minor code change - GLTFExporter didn't like running into vanilla Geometry objects.

@donmccurdy donmccurdy changed the title Adding GLTFExporter as a module in examples/jsm/exporters JSM: Adding GLTFExporter as a module in examples/jsm/exporters Mar 4, 2019
@mrdoob
Copy link
Owner

mrdoob commented Mar 15, 2019

#15977

@mrdoob mrdoob closed this Mar 15, 2019
@mrdoob
Copy link
Owner

mrdoob commented Mar 15, 2019

I regenerated the jsm files again 5349385
Do you mind checking if the file works for you?

@gkjohnson gkjohnson mentioned this pull request Mar 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codlaug @mrdoob