JSM Loaders: Create ES modules #15656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned here #15832 (comment), it's better to convert example files in small batches which can be easier reviewed. Thanks for the PR thought! |
|
Hi, Please let me know how you would like me to categorize them. I'll make separate PRs. |
|
I think any subset of files you’re comfortable manually testing would be great. With the conversion script, it’s the inspection of the result and testing that require most time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked if the examples are working. The below are not. I'm working on fixing them.
Guidance on how they can be fixed is appreciated.