161 -> 162 DragControls breaks for multiple groups

[jedleslie]

Description

I think this is related to the issue solved by PR #27791.

When enabling DragControls after 162, the Drag Controls onDrag handlers do not return the drag object inside the e.object. The drag object is one passed into the DragControls ctor, but when the events fire they are returning the parent object of that drag object.

Reproduction steps

1. Create a scene and add 2 group objects to the root of the scene
2. Enable just one of them in the DragControls ctor
3. View the onDrag event from the DragControls and see that it passses the object's parent as the "item being dragged" in the event.

Code

// code goes here

Live example

• jsfiddle-latest-release
• jsfiddle-dev

Screenshots

No response

Version

0.162

Device

Desktop

Browser

Chrome

OS

MacOS

[Mugen87]

Can you please demonstrate with a fiddle what's going wrong: https://jsfiddle.net/narenjcs/8ret1b9z/13/

It's currently not clear to me if this is a bug or if it is just the expected behavior.

[Mugen87]

I've created a fiddle by myself: https://jsfiddle.net/3cbrz8k4/3/

What we see is the expected behavior when enabling on transformGroup.

Objects organized in groups usually are logically connected so it makes sense when transformGroup is set to true, the entire group is affected. I understand there is the use case if just a single object of the hierarchy is added to the controls and transformGroup is set to true. In this case, users might expect the controls do not affect the hierarchy. But I'm unsure if this is right considering that enabling transformGroup should transform groups. That's the hole point of the property.

Nevertheless, we could basically check if the detected group is part of the objects array maintained by DragControls but that would potentially break other use cases which rely on the current behavior. As long as no other devs report the issue, let's keep the current default.

[Mugen87]

Nevertheless, we could basically check if the detected group is part of the objects array maintained by DragControls

Here is a custom version of DragControls that implements the suggested fix: https://jsfiddle.net/3bc8Lov7/

There is now a new helper function inObjects() that checks whether a found group belongs to the object hierarchies managed by DragControls.