OutputPass: shader does not compile if renderer.toneMapping is set

[WestLangley]

Description

Setting, for example,

renderer.toneMapping = THREE.ACESFilmicToneMapping;

will cause OutputPass shader to fail to compile.

Reproduction steps

1. Add renderer.toneMapping = THREE.ACESFilmicToneMapping to an example using OutputPass.

Code

renderer.toneMapping = THREE.ACESFilmicToneMapping

Live example

• jsfiddle-latest-release
• jsfiddle-dev

Screenshots

No response

Version

r154dev

Device

No response

Browser

No response

OS

No response

[Mugen87]

This happens because of GLSL redefinitions.

What is your use case for using OutputPass with inline tone mapping? I assumed this is no valid use case so I did not add support for this.

[WestLangley]

Yes, only NoToneMapping is correct when using RenderPass. I'm thinking it would be best for render pass to know that...

Also, I find it confusing that it is required to set tone mapping and exposure in two places: (1) for the renderer, and (2) for OutputPass.

[Mugen87]

Indeed, it was mentioned in #26102 (comment) that OutputPass ideally extracts the settings from the renderer.

I did not implement this yet because of the mentioned GLSL redefinitions in context ShaderMaterial. There is no runtime error with RawShaderMaterial however we can't include shader chunks with this material type. Not sure how to solve this yet.