You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discussed in #22237 we want to documentation to be consistent with the return type when nothing is returned in a method. While working on fixing this inconsistency I came across another.
In, for example, BufferAttribute the applyMatrix3, applyMatrix4 and applyNormalMatrix methods all return this. On the other hand the copy method also returns this (code) but has a return type of BufferAttribute while then clone method also has the return type of BufferAttribute while actually constructing a new BufferAttribute (code).
My question, while i'm changing the return types to undefined when nothing is returned do we also want to fix this? (We meaning I'll do it together with the undefined return types.)
And if we want to do this, how should it be.
What I would like to propose is the usage of this when this is actually returned and only the current type (in this case BufferAttribute) when a new class is being constructed.
Love to hear everybody's opinions.
The text was updated successfully, but these errors were encountered:
Thanks for bringing this topic up! It would be indeed good to clean up the return types.
What I would like to propose is the usage of this when this is actually returned and only the current type (in this case BufferAttribute) when a new class is being constructed.
Describe the problem
As discussed in #22237 we want to documentation to be consistent with the return type when nothing is returned in a method. While working on fixing this inconsistency I came across another.
In, for example, BufferAttribute the
applyMatrix3
,applyMatrix4
andapplyNormalMatrix
methods all returnthis
. On the other hand thecopy
method also returnsthis
(code) but has a return type ofBufferAttribute
while thenclone
method also has the return type ofBufferAttribute
while actually constructing a new BufferAttribute (code).My question, while i'm changing the return types to undefined when nothing is returned do we also want to fix this? (We meaning I'll do it together with the undefined return types.)
And if we want to do this, how should it be.
What I would like to propose is the usage of
this
when this is actually returned and only the current type (in this caseBufferAttribute
) when a new class is being constructed.Love to hear everybody's opinions.
The text was updated successfully, but these errors were encountered: