Phong and Standard materials are broken @ Adreno 308 Phones

[0b5vr]

Description of the problem

The examples for phong and standard materials are broken on Adreno 308 phones.
I'm gonna try other GPUs as well. did it, results below

Three.js version

r116

Environments

• Adreno 308

  • Android One S2, Android 8.0.0, Chrome 81
  • it LGV36, Android 8.1.0, Chrome 81
  • Galaxy J4+ SM-J415N, Android 8.1.1, Chrome 81

• DID NOT repro @ Adreno 306

  • Galaxy J5(2016) SM-J510S, Android 6.0.1, Chrome 81

• DID NOT repro @ Adreno 430

  • Xperia Z5 SO-01H, Android 7.0, Chrome 81

[0b5vr]

It seems that the reproducing range is extremely small, we might just want to ignore this......
I'm tweaking around shaders right now but I completely have no idea what is wrong with the issue

[mrdoob]

Was this the issue that required material.precision = 'mediump';?

[0b5vr]

Wow... you're right. material.precision = 'mediump' makes it work...

Honestly I'm not sure what should we do from here...

[Mugen87]

see #14137 (comment)

It means that the highp codepath on certain Adreno devices is buggy and the following WebGL conformance test should fail:

https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/misc/struct-as-inout-parameter.html?webglVersion=1&quiet=0&quick=1

It's a Qualcomm driver bug which is unlikely to be fixed.

[Mugen87]

Also related: #14570

[Mugen87]

Marking this issue as a duplicate of #14137.

[mrdoob]

@fms-cat

Honestly I'm not sure what should we do from here...

@bhouston proposed that we should try to use mediump by default in the library and fix any shaders that require changes.

[0b5vr]

I'm going to switch to mediump by the application side when the GPU is Adreno 308 for this time. Thanks for the info!

[arpu]

@fms-cat can you share the code to change this on Application level?

[0b5vr]

@fms-cat can you share the code to change this on Application level?

Using material.precision for each materials as noted above worked for me.

[arpu]

thx! if i set https://threejs.org/docs/#api/en/renderers/WebGLRenderer.precision does this set it for the material too? ( like for all materials i use like in glb models)

[Mugen87]

@arpu Yes, this is the default for all materials. You can overwrite it by setting precision on material level.