Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisiting the style guide etc in response to r106 #16927

Closed
greggman opened this issue Jun 27, 2019 · 1 comment
Closed

Revisiting the style guide etc in response to r106 #16927

greggman opened this issue Jun 27, 2019 · 1 comment

Comments

@greggman
Copy link
Contributor

greggman commented Jun 27, 2019

As of r106 all the examples now use es6 modules. I've been told more than once in the last year that some kind of code was unacceptable because it was not IE11 compatible.

For example here's one.

I know there are others.

But now that all the examples are using import the repo is decidedly not compatible with IE11. In fact it's not compatible with any browser before May 2017.

So, now that someone has finally decided to break compatibility with old browsers how about all rest?

  • template literals? yes/no
  • const and let? yes/no
  • destructuring? yes/no
  • class keyword? yes/no
  • Set? Map?
  • arrow functions
  • async/await

etc...

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 27, 2019

The builds of three.js still work in older browsers. Just migrating the examples to modules has not changed anything about this fact. Hence, I'm not sure it's the right opportunity to revisit this topic.

TBH, instead of creating a new issue, it's be better to continue the discussion here: #6419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants