Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTF2Loader -- support for CUBICSPLINE interpolation #11761

Closed
zellski opened this issue Jul 13, 2017 · 6 comments
Closed

GLTF2Loader -- support for CUBICSPLINE interpolation #11761

zellski opened this issue Jul 13, 2017 · 6 comments

Comments

@zellski
Copy link

zellski commented Jul 13, 2017

I've noticed that GLTF2Loader is undergoing fairly rapid iteration. Is there work in progress on supporting the new interpolation modes, most interestingly CUBICSPLINE? Of all the improvements from GLTF1 to GLTF2, getting away from densely sampled animation transforms (and the resulting enormous model files) is perhaps the most exciting.

If nobody else is working on this, we may end up taking a pass on it.

@donmccurdy
Copy link
Collaborator

Is there work in progress on supporting the new interpolation modes, most interestingly CUBICSPLINE?

Not started yet, no. Please do feel free to work on this. 🙂

/cc @takahirox

@donmccurdy
Copy link
Collaborator

Regarding the ongoing iteration, my own roadmap currently is:

  1. Supporting experimental Draco mesh compression extension for glTF
  2. KHR_cmnBlinnPhong extension
  3. Refactoring to allow glTF extensions to be authored without modifying GLTF2Loader itself.

@donmccurdy
Copy link
Collaborator

CUBICSPLINE interpolation added with #11825. If you have a test model available, might be good to verify.

@zellski
Copy link
Author

zellski commented Jul 23, 2017

Great work! I believe the Blender folks are adding support for spline interpolation in their exporter shortly. Meanwhile I might hack up a tiny test-file by hand.

@zellski zellski closed this as completed Nov 7, 2017
@donmccurdy donmccurdy reopened this Nov 7, 2017
@donmccurdy
Copy link
Collaborator

Unfortunately it looks like CUBICSPLINE interpolation will need some more work. I tried passing the glTF data directly into the three.js keyframe track and that wasn't it. Will need to read up on how both systems work and adapt the input data accordingly. See: #12233.

@zellski
Copy link
Author

zellski commented Nov 7, 2017

Aha, understood. You need a little McCurdy-minion to help you out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants