Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Support for SnippetTextEdits in CodeAction #412

Open
IndianBoy42 opened this issue May 28, 2024 · 3 comments · May be fixed by #420
Open

Full Support for SnippetTextEdits in CodeAction #412

IndianBoy42 opened this issue May 28, 2024 · 3 comments · May be fixed by #420
Labels
enhancement New feature or request

Comments

@IndianBoy42
Copy link
Contributor

Feature description

It would be nice to have support for SnippetTextEdits in code actions considering how much rust-analyzer uses it for assists

https://github.com/rust-lang/rust-analyzer/blob/master/docs/dev/lsp-extensions.md#snippet-textedit

its actually part of the upcoming 3.18 lsp protocol, but I don't know when that means neovim core will support it.
I don't know if native vim.snippets supports enough for it but actually either way it would be nice for the snippet function to be overridable so, for example, LuaSnip users can use it with LuaSnip

Reference: L3MON4D3/LuaSnip#235

Half? an implementation previously: https://github.com/simrat39/rust-tools.nvim/tree/snippet_text_edits

@IndianBoy42 IndianBoy42 added the enhancement New feature or request label May 28, 2024
@IndianBoy42 IndianBoy42 changed the title Full Support for SnippetTextEdits Full Support for SnippetTextEdits in CodeAction May 28, 2024
@mrcjkb
Copy link
Owner

mrcjkb commented Jun 7, 2024

Hey 👋

I will gladly look into picking this up. However, it looks like it will take some time, as there may be things that need to be ironed out in luasnip.

@mrcjkb mrcjkb linked a pull request Jun 7, 2024 that will close this issue
@JeanMertz

This comment was marked as duplicate.

@mrcjkb

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants