address comments

app/server/src/static-site-builder/wodinBuilder.ts

@@ -30,8 +30,6 @@ if (fs.existsSync(appsPathFull)) {
 }
 fs.mkdirSync(appsPathFull);
 
-const sessionId = null;
-const shareNotFound = null;
 const baseUrl = wodinConfig.baseUrl.replace(/\/$/, "");
 
 const appNames = fs.readdirSync(path.resolve(configPath, wodinConfig.appsPath)).map(fileName => {
@@ -83,8 +81,8 @@ appNames.forEach(async appName => {
         appTitle: config.title,
         courseTitle: wodinConfig.courseTitle,
         wodinVersion,
-        loadSessionId: sessionId || "",
-        shareNotFound: shareNotFound || "",
+        loadSessionId: "",
+        shareNotFound: "",
         mathjaxSrc: "https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-chtml.js",
         enableI18n: wodinConfig.enableI18n ?? false, // if option not set then false by default
         defaultLanguage: wodinConfig?.defaultLanguage || "en",

app/static/src/components/code/CodeEditor.vue

@@ -1,7 +1,7 @@
 <template>
     <div>
         <button
-            v-if="defaultCodeExists && !STATIC_BUILD"
+            v-if="defaultCodeExists && !readOnly"
             class="btn btn-primary btn-sm mb-2"
             id="reset-btn"
             v-help="'resetCode'"
@@ -24,7 +24,6 @@ import Timeout = NodeJS.Timeout;
 import { AppConfig, OdinModelResponse } from "../../types/responseTypes";
 import { CodeAction } from "../../store/code/actions";
 import { CodeMutation } from "../../store/code/mutations";
-import { STATIC_BUILD } from "@/parseEnv";
 
 interface DecorationOptions {
     range: {
@@ -190,8 +189,7 @@ export default defineComponent({
             editor,
             readOnly,
             resetCode,
-            defaultCodeExists,
-            STATIC_BUILD
+            defaultCodeExists
         };
     }
 });

app/static/src/components/code/CodeTab.vue

@@ -2,7 +2,7 @@
     <div v-if="appIsConfigured" class="code-tab">
         <generic-help title="Write odin code" :markdown="codeHelp"></generic-help>
         <code-editor />
-        <div v-if="!STATIC_BUILD">
+        <div v-if="!readOnly">
             <button class="btn btn-primary mt-2" id="compile-btn" :disabled="!codeIsValid" @click="compile">Compile</button>
             <div class="mt-2" id="code-status" :class="codeValidating ? 'code-validating-text' : ''">
                 <vue-feather
@@ -33,7 +33,7 @@ import userMessages from "../../userMessages";
 import ErrorInfo from "../ErrorInfo.vue";
 import GenericHelp from "../help/GenericHelp.vue";
 import GraphConfigsCollapsible from "../graphConfig/GraphConfigsCollapsible.vue";
-import { STATIC_BUILD } from "@/parseEnv";
+import { AppConfig } from "@/types/responseTypes";
 
 export default defineComponent({
     name: "CodeTab",
@@ -47,6 +47,7 @@ export default defineComponent({
     },
     setup() {
         const store = useStore();
+        const readOnly = computed(() => (store.state.config as AppConfig).readOnlyCode);
         const codeIsValid = computed(() => store.state.model.odinModelResponse?.valid);
         const codeValidating = computed(() => store.state.code.loading);
         const error = computed(() => store.state.model.odinModelCodeError);
@@ -70,7 +71,7 @@ export default defineComponent({
             codeHelp,
             codeValidating,
             loadingMessage,
-            STATIC_BUILD
+            readOnly
         };
     }
 });

app/static/src/router.ts

@@ -8,6 +8,10 @@ import type StochasticApp from "./components/stochastic/StochasticApp.vue";
 type UnionAppComponent = typeof BasicApp | typeof FitApp | typeof StochasticApp
 type IntersectionAppComponent = typeof BasicApp & typeof FitApp & typeof StochasticApp
 
+// this type just extracts the intersection of props that all of the app components accept
+// by getting the type of the first argument in setup function (which are props)
+type IntersectedTabProp = Parameters<NonNullable<IntersectionAppComponent["setup"]>>["0"];
+
 export function initialiseRouter(
     appComponent: UnionAppComponent,
     appName: string,
@@ -34,7 +38,7 @@ export function initialiseRouter(
         component: appComponent,
         props: {
             initSelectedTab: STATIC_BUILD ? "Options" : undefined
-        } as Parameters<NonNullable<IntersectionAppComponent["setup"]>>["0"]
+        } as IntersectedTabProp
     };
 
     const sessionsRoute: RouteRecordRaw = {

app/static/src/store/appState/actions.ts

@@ -13,6 +13,7 @@ import { SessionsAction } from "../sessions/actions";
 import { localStorageManager } from "../../localStorageManager";
 import { AppStateGetter } from "./getters";
 import { InitialiseAppPayload, InitialiseSessionPayload } from "../../types/payloadTypes";
+import { STATIC_BUILD } from "@/parseEnv";
 
 export enum AppStateAction {
     InitialiseApp = "InitialiseApp",
@@ -97,7 +98,7 @@ export const appStateActions: ActionTree<AppState, AppState> = {
         };
 
         // Do not queue uploads while fitting is true, or while running sensitivity - we'll upload when finished
-        if (!isBusy()) {
+        if (!isBusy() && !STATIC_BUILD) {
             // remove any existing queued upload, as this request should supersede it
             commit(AppStateMutation.ClearQueuedStateUpload);
 
@@ -110,7 +111,7 @@ export const appStateActions: ActionTree<AppState, AppState> = {
                         immediateUploadState(context);
                     }
                 },
-                state.config?.stateUploadIntervalMillis
+                state.config?.stateUploadIntervalMillis || 2000
             );
 
             // record the newly queued upload

app/static/src/store/appState/mutations.ts

@@ -4,6 +4,7 @@ import { AppConfig } from "../../types/responseTypes";
 import { InitialiseAppPayload } from "../../types/payloadTypes";
 import registerTranslations from "../../../translationPackage/registerTranslations";
 import { collectedTranslations } from "../translations/collectedTranslations";
+import { STATIC_BUILD } from "@/parseEnv";
 
 export enum AppStateMutation {
     SetApp = "SetApp",
@@ -38,6 +39,9 @@ export const appStateMutations: MutationTree<AppState> = {
     },
 
     [AppStateMutation.SetConfig](state: AppState, payload: AppConfig) {
+        if (STATIC_BUILD) {
+            payload.readOnlyCode = true;
+        }
         state.config = payload;
     },